Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Build gtest unit tests #4492

Merged
merged 6 commits into from
Nov 15, 2021
Merged

[flutter_plugin_tools] Build gtest unit tests #4492

merged 6 commits into from
Nov 15, 2021

Conversation

@stuartmorgan-g
Copy link
Contributor

Builds Windows and Linux unit tests before running them in
native-test, in order to match the behavior of other platforms and
significantly improve the UX of running the command locally while
changing tests.

Fixes flutter/flutter#89303

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.
@stuartmorgan-g
[flutter_plugin_tools] Build gtest unit tests
204c743 
Builds Windows and Linux unit tests before running them in `native-test`, in order to match the behavior of other platforms and significantly improve the UX of running the command locally while changing tests. Fixes flutter/flutter#89303
@google-cla google-cla bot added the cla: yes label Nov 9, 2021
stuartmorgan-g
stuartmorgan-g commented Nov 9, 2021
View reviewed changes
packages/url_launcher/url_launcher/example/linux/flutter/CMakeLists.txt
"${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.sh"
linux-x64 ${CMAKE_BUILD_TYPE}
${FLUTTER_TARGET_PLATFORM} ${CMAKE_BUILD_TYPE}
VERBATIM
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are auto-migrations by flutter that have just never been checked in.
packages/url_launcher/url_launcher/example/windows/flutter/generated_plugin_registrant.cc
UrlLauncherPluginRegisterWithRegistrar(
registry->GetRegistrarForPlugin("UrlLauncherPlugin"));
UrlLauncherWindowsRegisterWithRegistrar(
registry->GetRegistrarForPlugin("UrlLauncherWindows"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I forgot to check in the updated generated registrant when I restructured the plugin for unit testability.
gaaclarke
gaaclarke approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just a few minor observations.
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 15, 2021
@fluttergithubbot fluttergithubbot merged commit 8d0382e into flutter:master Nov 15, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2021
@engine-flutter-autoroll
8d0382e [flutter_plugin_tools] Build gtest unit tests (flutter/plugin…
3227650 
…s#4492)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan-g @amantoux
[flutter_plugin_tools] Build gtest unit tests (flutter#4492)
9adc76f
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
[flutter_plugin_tools] Build gtest unit tests (flutter#4492)
724db00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: url_launcher platform-linux platform-windows waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

4 participants

@stuartmorgan-g @gaaclarke @fluttergithubbot @stuartmorgan