Guard against null values for paymentDiscount

Author: mvanbeusekom

packages/in_app_purchase/in_app_purchase_ios/example/ios/RunnerTests/TranslatorTests.m

@@ -200,4 +200,74 @@ - (void)testSKPaymentDiscountFromMap {
  }
 }
 
+- (void)testSKPaymentDiscountFromMapMissingIdentifier {
+ if (@available(iOS 12.2, *)) {
+ NSDictionary* discountMap = @{
+ @"keyIdentifier" : @"payment_discount_key_identifier",
+ @"nonce" : @"d18981e0-9003-4365-98a2-4b90e3b62c52",
+ @"signature" : @"this is a encrypted signature",
+ @"timestamp" : @([NSDate date].timeIntervalSince1970),
+ };
+ 
+ XCTAssertThrows(
+ [FIAObjectTranslator getSKPaymentDiscountFromMap:discountMap]);
+ }
+}
+ 
+- (void)testSKPaymentDiscountFromMapMissingKeyIdentifier {
+ if (@available(iOS 12.2, *)) {
+ NSDictionary* discountMap = @{
+ @"identifier" : @"payment_discount_identifier",
+ @"nonce" : @"d18981e0-9003-4365-98a2-4b90e3b62c52",
+ @"signature" : @"this is a encrypted signature",
+ @"timestamp" : @([NSDate date].timeIntervalSince1970),
+ };
+ 
+ XCTAssertThrows(
+ [FIAObjectTranslator getSKPaymentDiscountFromMap:discountMap]);
+ }
+}
+
+- (void)testSKPaymentDiscountFromMapMissingNonce {
+ if (@available(iOS 12.2, *)) {
+ NSDictionary* discountMap = @{
+ @"identifier" : @"payment_discount_identifier",
+ @"keyIdentifier" : @"payment_discount_key_identifier",
+ @"signature" : @"this is a encrypted signature",
+ @"timestamp" : @([NSDate date].timeIntervalSince1970),
+ };
+ 
+ XCTAssertThrows(
+ [FIAObjectTranslator getSKPaymentDiscountFromMap:discountMap]);
+ }
+}
+
+- (void)testSKPaymentDiscountFromMapMissingSignature {
+ if (@available(iOS 12.2, *)) {
+ NSDictionary* discountMap = @{
+ @"identifier" : @"payment_discount_identifier",
+ @"keyIdentifier" : @"payment_discount_key_identifier",
+ @"nonce" : @"d18981e0-9003-4365-98a2-4b90e3b62c52",
+ @"timestamp" : @([NSDate date].timeIntervalSince1970),
+ };
+ 
+ XCTAssertThrows(
+ [FIAObjectTranslator getSKPaymentDiscountFromMap:discountMap]);
+ }
+}
+
+- (void)testSKPaymentDiscountFromMapMissingTimestamp {
+ if (@available(iOS 12.2, *)) {
+ NSDictionary* discountMap = @{
+ @"identifier" : @"payment_discount_identifier",
+ @"keyIdentifier" : @"payment_discount_key_identifier",
+ @"nonce" : @"d18981e0-9003-4365-98a2-4b90e3b62c52",
+ @"signature" : @"this is a encrypted signature",
+ };
+ 
+ XCTAssertThrows(
+ [FIAObjectTranslator getSKPaymentDiscountFromMap:discountMap]);
+ }
+}
+
 @end

packages/in_app_purchase/in_app_purchase_ios/ios/Classes/FIAObjectTranslator.m

@@ -209,9 +209,15 @@ + (NSDictionary *)getMapFromSKStorefront:(SKStorefront *)storefront
 }
 
 + (SKPaymentDiscount *)getSKPaymentDiscountFromMap:(NSDictionary *)map {
- if (!map) {
+ if (!map || map.count <= 0) {
  return nil;
  }
+ 
+ NSAssert(map[@"identifier"], @"When specifying a payment discount the 'identifier' field is mandatory.");
+ NSAssert(map[@"keyIdentifier"], @"When specifying a payment discount the 'keyIdentifier' field is mandatory.");
+ NSAssert(map[@"nonce"], @"When specifying a payment discount the 'nonce' field is mandatory.");
+ NSAssert(map[@"signature"], @"When specifying a payment discount the 'signature' field is mandatory.");
+ NSAssert(map[@"timestamp"], @"When specifying a payment discount the 'timestamp' field is mandatory.");
 
  NSString *identifier = map[@"identifier"];
  NSString *keyIdentifier = map[@"keyIdentifier"];