Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Override FlutterPlatformNodeDelegate::GetUniqueId #30261

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Override FlutterPlatformNodeDelegate::GetUniqueId #30261

merged 1 commit into from
Dec 10, 2021

Conversation

@cbracken
Copy link
Member

The default implementation of GetUniqueId on ui::AXPlatformNodeDelegate
always returns ID 1. We had previously implemented this on the windows
platform node delegate, but for consistency's sake, and because the
default implementation is surprising, we're promoting this to the
FlutterPlatformNodeDelegate base class.

Issue: flutter/flutter#77838

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.
@cbracken
Override FlutterPlatformNodeDelegate::GetUniqueId
6b26d54 
The default implementation of GetUniqueId on ui::AXPlatformNodeDelegate always returns ID 1. We had previously implemented this on the windows platform node delegate, but for consistency's sake, and because the default implementation is surprising, we're promoting this to the FlutterPlatformNodeDelegate base class. Issue: flutter/flutter#77838
chunhtai
chunhtai approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@cbracken cbracken merged commit 71fdb89 into flutter:main Dec 10, 2021
@cbracken cbracken deleted the unique_id-to-base-class branch December 10, 2021 18:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
80a1e20 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
5a726bf 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
59f4e4f 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
fc6e534 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
0208155 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
55b0380 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
648eb54 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
6250334 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
b414f8e 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
2cbf836 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
b0424eb 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
ab3eb0a 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
d2fd4e1 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
f0d3e49 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
cab38fe 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
97e671e 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
ce04276 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
be1a497 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
a7837db 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
19a0202 
…gine#30261)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/en…
511a00f 
…gine#30261)
zanderso pushed a commit to flutter/flutter that referenced this pull request Dec 12, 2021
@engine-flutter-autoroll
Roll Engine from 79f750d to 368e3cc (31 revisions) (#95132)
3670926 
* 37223ca [fuchsia] Use network-legacy-deprecated pkg in embedder test (flutter/engine#30244) * 86769ee Roll Dart SDK from 2ace65b1b408 to 2091ff49c513 (8 revisions) (flutter/engine#30251) * 5312e55 Win32: Handle OnAccessibilityEvent (flutter/engine#30176) * 8fd8912 Revert the latest rolls of the Fuchsia SDK (flutter/engine#30254) * df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine#30256) * 6aa8d5c Simplify win32 platform node delegate GetParent (flutter/engine#30258) * ff328f0 Fix TestAccessibilityBridgeDelegate event caching (flutter/engine#30260) * 842281e Test shell/platform/common a11y code on Windows (flutter/engine#30262) * 806d8bc Roll Dart SDK from 2091ff49c513 to 7b6056f9db7f (1 revision) (flutter/engine#30259) * 1ed10bb Android accessibility bridge also fire selection change event when it predict selection change. (flutter/engine#30199) * 71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/engine#30261) * 5aa7b30 Cleanup old ndk CIPD upload script (flutter/engine#30253) * 3653881 Roll Fuchsia Mac SDK from EcjcLVqar... to 1DgBWWOWV... (flutter/engine#30265) * f764864 Roll Skia from 44c81d149273 to a964a72174e8 (9 revisions) (flutter/engine#30255) * 2eca05e Migrate to Mockito 4.1.0 (flutter/engine#30257) * 1a6005f Add iOS version to scenario golden images (flutter/engine#30263) * 59c6f28 Roll Fuchsia Linux SDK from 3rLypXNTd... to UPWdoQziF... (flutter/engine#30266) * 5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engine#30182) * bb20dd0 Roll Skia from a964a72174e8 to 4d35c0d31d79 (16 revisions) (flutter/engine#30269) * 33f4c32 Revert "Accessibility number formatting improvements for Windows (#29773)" (flutter/engine#30267) * 5ece42f Roll Dart SDK from 7b6056f9db7f to f568598a262e (4 revisions) (flutter/engine#30270) * 8d1272b Roll Dart SDK from f568598a262e to 49d5a2f58c4a (3 revisions) (flutter/engine#30277) * 8b074c8 Roll Fuchsia Mac SDK from 1DgBWWOWV... to GoQ7KEnqp... (flutter/engine#30278) * e1a71cf Roll Fuchsia Linux SDK from UPWdoQziF... to hhFGKobVD... (flutter/engine#30279) * 6dc4046 Roll Fuchsia Mac SDK from GoQ7KEnqp... to Y_9lCzY64... (flutter/engine#30280) * ff7d4d6 Roll Fuchsia Linux SDK from hhFGKobVD... to NAkkk-Vn5... (flutter/engine#30281) * 2f97ac4 Roll Dart SDK from 49d5a2f58c4a to 01a9d4e9ede7 (1 revision) (flutter/engine#30283) * 85f4d68 Roll Fuchsia Linux SDK from NAkkk-Vn5... to V2JLZw4H1... (flutter/engine#30285) * 5130b83 Roll Fuchsia Mac SDK from Y_9lCzY64... to xBCcWw6gj... (flutter/engine#30284) * e28882a Roll Dart SDK from 01a9d4e9ede7 to a78eae43582d (1 revision) (flutter/engine#30288) * 368e3cc Revert Dart SDK to 2ace65b1b408 (flutter/engine#30290)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-windows

2 participants

@cbracken @chunhtai