Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Nov 25, 2021

It fixes:

The unique_ptr of platform_view lives with the shell instance, so I leave a comment, pass the pointer to the io_task_runner and call platform_view_ptr->CreateResourceContext().

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@eggfly
Copy link
Member Author

eggfly commented Nov 25, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

I think it passes all current tests and that is OK enough.

@eggfly
Copy link
Member Author

eggfly commented Nov 25, 2021

@chinmaygarde @darshankawar @kf6gpe @gw280 Hello~ please take a short review, thank you! 😁

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 30, 2021
@fluttergithubbot fluttergithubbot merged commit 2aaf6ec into flutter:main Nov 30, 2021
@eggfly eggfly deleted the main_remove_getunsafe branch November 30, 2021 06:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

4 participants