Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable embedder tests on Windows #29624

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Re-enable embedder tests on Windows #29624

merged 1 commit into from
Nov 9, 2021

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Nov 9, 2021

These were disabled due to failures opening files and a crash fixed by
#29621.

Issue: flutter/flutter#36294

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.
@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@cbracken cbracken merged commit 6ecc390 into flutter:master Nov 9, 2021
@cbracken cbracken deleted the reenable-embedder-tests-win branch November 9, 2021 21:42
@cbracken cbracken mentioned this pull request Nov 9, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
db45ccd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
fa6c6a9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
5909f32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
339775e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
fd13515
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
ae3550d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
fb3594b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
ee8e04a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
5433315
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
d30b4f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
85406f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
6ecc390 Re-enable embedder tests on Windows (flutter/engine#29624)
4dadec9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

2 participants

@cbracken @gw280