Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 15b6415

Browse files
committed
dan feedback
1 parent 0ba85eb commit 15b6415

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1185,6 +1185,7 @@ FILE: ../../../flutter/shell/platform/darwin/ios/ios_switchable_gl_context.h
11851185
FILE: ../../../flutter/shell/platform/darwin/ios/ios_switchable_gl_context.mm
11861186
FILE: ../../../flutter/shell/platform/darwin/ios/platform_message_handler_ios.h
11871187
FILE: ../../../flutter/shell/platform/darwin/ios/platform_message_handler_ios.mm
1188+
FILE: ../../../flutter/shell/platform/darwin/ios/platform_message_handler_ios_test.mm
11881189
FILE: ../../../flutter/shell/platform/darwin/ios/platform_view_ios.h
11891190
FILE: ../../../flutter/shell/platform/darwin/ios/platform_view_ios.mm
11901191
FILE: ../../../flutter/shell/platform/darwin/ios/rendering_api_selection.h

shell/platform/darwin/common/framework/Source/FlutterChannelsTest.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ - (void)testMethodMessageHandler {
108108
OCMStub([codec encodeMethodCall:[OCMArg any]]).andReturn(encodedMethodCall);
109109
FlutterMethodCallHandler handler =
110110
^(FlutterMethodCall* _Nonnull call, FlutterResult _Nonnull result) {
111-
NSLog(@"hey");
112111
};
113112
[channel setMethodCallHandler:handler];
114113
OCMVerify([binaryMessenger setMessageHandlerOnChannel:channelName
@@ -175,7 +174,6 @@ - (void)testBasicMessageChannelCleanup {
175174
binaryMessenger:binaryMessenger
176175
codec:codec];
177176
FlutterMessageHandler handler = ^(id _Nullable message, FlutterReply callback) {
178-
NSLog(@"hey");
179177
};
180178
OCMStub([binaryMessenger setMessageHandlerOnChannel:channelName
181179
binaryMessageHandler:[OCMArg any]])
@@ -223,7 +221,6 @@ - (void)testBasicMessageChannelTaskQueue {
223221
codec:codec
224222
taskQueue:taskQueue];
225223
FlutterMessageHandler handler = ^(id _Nullable message, FlutterReply callback) {
226-
NSLog(@"hey");
227224
};
228225
OCMStub([binaryMessenger setMessageHandlerOnChannel:channelName
229226
binaryMessageHandler:[OCMArg any]
@@ -249,7 +246,6 @@ - (void)testMethodChannelTaskQueue {
249246
taskQueue:taskQueue];
250247
XCTAssertNotNil(channel);
251248
FlutterMethodCallHandler handler = ^(FlutterMethodCall* call, FlutterResult result) {
252-
NSLog(@"hey");
253249
};
254250
OCMStub([binaryMessenger setMessageHandlerOnChannel:channelName
255251
binaryMessageHandler:[OCMArg any]

shell/platform/darwin/ios/platform_message_handler_ios.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,13 @@ - (void)dispatch:(dispatch_block_t)block {
9090
int response_id,
9191
std::unique_ptr<fml::Mapping> mapping) {
9292
// Called from any thread.
93-
// TODO(gaaclarke: This vestigal from the Android implementation, find a way
93+
// TODO(gaaclarke): This vestigal from the Android implementation, find a way
9494
// to migrate this to PlatformMessageHandlerAndroid.
9595
}
9696

9797
void PlatformMessageHandlerIos::InvokePlatformMessageEmptyResponseCallback(int response_id) {
9898
// Called from any thread.
99-
// TODO(gaaclarke: This vestigal from the Android implementation, find a way
99+
// TODO(gaaclarke): This vestigal from the Android implementation, find a way
100100
// to migrate this to PlatformMessageHandlerAndroid.
101101
}
102102

0 commit comments

Comments
 (0)