Skip to content

Conversation

@sorah
Copy link
Member

@sorah sorah commented Nov 15, 2010

iconv is obsolete in 1.9.3+ (trunk), so I removed iconv when using 1.9+

% ruby -riconv -e0 iconv will be deprecated in the future, use String#encode instead. 

tests are passed.

@tenderlove
Copy link
Member

+1, this should be applied.

@kristianmandrup
Copy link

How do I install the 1.5.0 version or any version patched to remove iconv for ruby 1.9.3+ ;) I tried the following with no success...

Gemfile
gem 'json', :git => 'https://github.com/flori/json.git'

$ bundle install && bundle update

$ gem install flori-json --source http://gems.github.com

$ gem install json -v 1.5.0

@kristianmandrup
Copy link

$ bundle update json
Fetching git://github.com/flori/json.git
Fetching source index for http://rubygems.org/
Could not find gem 'json (>= 0, runtime)' in git://github.com/flori/json.git (at master).
Source does not contain any versions of 'json (>= 0, runtime)'

@sorah
Copy link
Member Author

sorah commented Dec 7, 2010

Because it doesn't merged now...

use an branch never_use_iconv on https://github.com/sorah/json.git .

Author doesn't reply about a month...

HINT: ruby-head merged my patch.

@kristianmandrup
Copy link

oh, so if I get the latest 1.9.3-head it should work?

Gemfile
gem 'json', :branch => 'never_use_iconv', :git => 'https://github.com/sorah/json.git'

$ bundle install && bundle update

Updating https://github.com/sorah/json.git
Fetching source index for http://rubygems.org/
Could not find gem 'json (>= 0, runtime)' in https://github.com/sorah/json.git (at never_use_iconv).
Source does not contain any versions of 'json (>= 0, runtime)'

Damn! Is it coz I'm using https protocol or what!?

@sorah
Copy link
Member Author

sorah commented Dec 7, 2010

try git://github.com/sorah/json

@kristianmandrup
Copy link

Same error... :( I think the problem might be, that the .gemspec file is not pushed to github?

Could not find gem 'json (>= 0, runtime)' in git://github.com/sorah/json (at never_use_iconv).
Source does not contain any versions of 'json (>= 0, runtime)'

@sorah
Copy link
Member Author

sorah commented Dec 7, 2010

I think doesn't pushed.
Please fork and rake .gemspec and push, then use at bundler.

@kristianmandrup
Copy link

So I forked, checked out the never_use_iconv branch. Then tried running rake...

WARNING: rake-compiler is not installed. You will not be able to build the json gem until you install it.

First need to install rake-compiler: $ gem install rake-compiler
$ rake
rake-compiler must be configured first to enable cross-compilation

Then I have to configure it for cross compilation.
$ rake-compiler cross-ruby

No MinGW tools or unknown setup platform?

So I have to install MinGW I guess?

http://rake-compiler.rubyforge.org/

Besides having the development tool chain installed (GCC), you should install also mingw32 cross compilation package.

Installation depends will depend on your operating system/distribution. On Ubuntu and Debian machines, a simple apt-get install mingw32 will be enough.

On OSX, mingw32 is available via MacPorts: port install i386-mingw32-gcc (ensure you update your ports tree before hand as mingw32 has been been broken).

Hmm, except I am normally using homebrew. So I try this:

http://crossgcc.rts-software.org/doku.php

There is an installer for Mac OS X Intell

http://crossgcc.rts-software.org/download/MinGW%204.3.0%20for%20Mac%20OS%20X%20(Intel).pkg.tar.bz2

Not so easy... Now I installed MingW 4.3 - smooth sailing from here???

@flori
Copy link
Member

flori commented Jan 4, 2011

should be in the trunk version now

@sorah
Copy link
Member Author

sorah commented Jan 5, 2011

A Committer commited this patch early because you doesn't reply for long time.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants