Skip to content

Conversation

@unicornware
Copy link
Member

Description

Makes postinstall script work as expected when package is installed from git.

The script now checks for the existence of ./node_modules/bin/husky before attempting to install husky.

Tests

postinstall script works as expected. see #11 for details.

Linked issues

Related documents

N/A

Additional context

N/A

Submission checklist

  • self-review performed
  • tests added and/or updated
  • documentation added or updated
  • new, tolerable vulnerabilities and/or warnings documented, if any
  • pr naming conventions
- checks for husky executable before attempting to install husky Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
@unicornware unicornware added type:fix bug reports and fixes scope:install package install labels Dec 26, 2022
@unicornware unicornware self-assigned this Dec 26, 2022
@unicornware unicornware linked an issue Dec 26, 2022 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #13 (90c5b99) into main (97adaf9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@ Coverage Diff @@ ## main #13 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 1992 1992 Branches 148 148 ========================================= Hits 1992 1992 
Flag Coverage Δ
node14 100.00% <ø> (ø)
node16 100.00% <ø> (ø)
node18 100.00% <ø> (ø)
node19 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97adaf9...90c5b99. Read the comment docs.

@unicornware unicornware enabled auto-merge (squash) December 26, 2022 00:47
Copy link
Contributor

@flexdevelopment flexdevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@unicornware unicornware merged commit c063f13 into main Dec 26, 2022
@unicornware unicornware deleted the hotfix/11-install-command-failed branch December 26, 2022 02:14
@unicornware unicornware mentioned this pull request Dec 26, 2022
5 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent
activity after it was closed. Please open a new issue for related bugs or features. Be
sure to reference this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope:install package install type:fix bug reports and fixes

3 participants