Add sample for opentelemetry-js #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
taeold force-pushed the dl-cf3v2-otel-sample branch from 641dc30 to de31e79 Compare 
taeold force-pushed the dl-cf3v2-otel-sample branch from de31e79 to cfa9457 Compare 
jhuleatt reviewed Oct 17, 2022
jhuleatt reviewed Oct 17, 2022
jhuleatt reviewed Oct 17, 2022
jhuleatt approved these changes Oct 17, 2022
Collaborator
jhuleatt left a comment
jhuleatt left a comment There was a problem hiding this comment.
Overall LGTM! Left a couple of suggestions.
It may also be worth naming this folder more in line with the problem it solves. Something like 2nd-gen/instrument-with-opentelemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sample code with callable function instrumented with opentelemetry-js.