Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 22, 2025

Updated the default dart import syntax.

// Before import 'dataconnect_generated/movies.dart'; // After import 'dataconnect_generated/generated.dart'; 
  • Enforce source conforms to the type. Made a typo before.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the configuration for Dart SDK generation within Flutter projects integrated with Data Connect. The core change ensures that the generated Dart SDK package name correctly reflects the generated.dart file, aligning with common practices for generated code in Dart/Flutter environments. This update specifically targets the package field in the dartSdk configuration for the FLUTTER platform.

Highlights

  • Dart SDK Package Name Update: The Dart SDK package name for Flutter projects utilizing Data Connect has been updated to include generated.dart in its path, changing from dataconnect_generated to dataconnect_generated/generated.dart.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package name for the generated Dart SDK to include the filename generated.dart. While this change appears to be a necessary fix for the SDK generation process, I've noted an inconsistency in how the package property is used for Dart compared to other platforms, which could be improved for better clarity and maintainability in the future.

@fredzqm fredzqm requested a review from joehan October 22, 2025 21:17
void trackGA4(
"dataconnect_init",
{
source: setup.featureInfo?.dataconnectSource || "cli_sdk",
Copy link
Contributor Author

@fredzqm fredzqm Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a typo here. cli_sdk wasn't a valid Source

Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fredzqm fredzqm enabled auto-merge (squash) October 22, 2025 21:27
@fredzqm fredzqm merged commit 7b66779 into master Oct 22, 2025
48 checks passed
@fredzqm fredzqm deleted the fz/dark-import-libname branch October 22, 2025 22:29
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants