Add missing JSON.stringify in database:settings:set #3217
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3228
The namespace server expects string-value
.settings/<setting>.jsonvalues to be quoted. FordefaultWriteSizeLimit, this meant that passingunlimitedbroke with this error log infirebase-debug.log:Sample Commands
I tried setting the two supported database settings:
And:
And they both set the setting to the appropriate value. This change should also be robust to setting
rulesfrom the CLI.