Skip to content

Commit 8697759

Browse files
Add support for service account in functions (#2580)
Co-authored-by: joehan <joehanley@google.com>
1 parent 5baa1d5 commit 8697759

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/deploy/functions/release.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ module.exports = function(context, options, payload) {
267267
environmentVariables: defaultEnvVariables,
268268
vpcConnector: functionInfo.vpcConnector,
269269
vpcConnectorEgressSettings: functionInfo.vpcConnectorEgressSettings,
270+
serviceAccountEmail: functionInfo.serviceAccountEmail,
270271
})
271272
.then((createRes) => {
272273
if (_.has(functionTrigger, "httpsTrigger")) {
@@ -344,6 +345,7 @@ module.exports = function(context, options, payload) {
344345
maxInstances: functionInfo.maxInstances,
345346
vpcConnector: functionInfo.vpcConnector,
346347
vpcConnectorEgressSettings: functionInfo.vpcConnectorEgressSettings,
348+
serviceAccountEmail: functionInfo.serviceAccountEmail,
347349
environmentVariables: _.assign(
348350
{},
349351
existingFunction.environmentVariables,

src/gcp/cloudfunctions.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ function _createFunction(options) {
9696
if (options.environmentVariables) {
9797
data.environmentVariables = options.environmentVariables;
9898
}
99+
if (options.serviceAccountEmail) {
100+
data.serviceAccountEmail = options.serviceAccountEmail;
101+
}
99102

100103
return api
101104
.request("POST", endpoint, {
@@ -198,6 +201,10 @@ function _updateFunction(options) {
198201
data.environmentVariables = options.environmentVariables;
199202
masks.push("environmentVariables");
200203
}
204+
if (options.serviceAccountEmail) {
205+
data.serviceAccountEmail = options.serviceAccountEmail;
206+
masks.push("serviceAccountEmail");
207+
}
201208
if (options.trigger.eventTrigger) {
202209
masks = _.concat(
203210
masks,

0 commit comments

Comments
 (0)