Addressing review comments.

Author: MarkDuckworth

packages/firestore/src/lite-api/database.ts

@@ -41,15 +41,15 @@ import { cast } from '../util/input_validation';
 import { logWarn } from '../util/log';
 
 import { FirestoreService, removeComponents } from './components';
+// `import type` to avoid bundling the source for
+// pipelines if `useFirestorePipelines()` is not called
 import type { PipelineSource } from './pipeline-source';
 import {
  DEFAULT_HOST,
  FirestoreSettingsImpl,
  PrivateSettings,
  FirestoreSettings
 } from './settings';
-// `import type` to avoid bundling the source for
-// pipelines if `useFirestorePipelines()` is not called
 
 export { EmulatorMockTokenOptions } from '@firebase/util';
 

packages/firestore/src/lite-api/user_data_reader.ts

@@ -437,68 +437,6 @@ export function parseSetData(
  );
 }
 
-export function parse(
- userDataReader: UserDataReader,
- methodName: string,
- targetDoc: DocumentKey,
- input: unknown,
- hasConverter: boolean,
- options: SetOptions = {}
-): ParsedSetData {
- const context = userDataReader.createContext(
- options.merge || options.mergeFields
- ? UserDataSource.MergeSet
- : UserDataSource.Set,
- methodName,
- targetDoc,
- hasConverter
- );
- validatePlainObject('Data must be an object, but it was:', context, input);
- const updateData = parseObject(input, context)!;
-
- let fieldMask: FieldMask | null;
- let fieldTransforms: FieldTransform[];
-
- if (options.merge) {
- fieldMask = new FieldMask(context.fieldMask);
- fieldTransforms = context.fieldTransforms;
- } else if (options.mergeFields) {
- const validatedFieldPaths: InternalFieldPath[] = [];
-
- for (const stringOrFieldPath of options.mergeFields) {
- const fieldPath = fieldPathFromArgument(
- methodName,
- stringOrFieldPath,
- targetDoc
- );
- if (!context.contains(fieldPath)) {
- throw new FirestoreError(
- Code.INVALID_ARGUMENT,
- `Field '${fieldPath}' is specified in your field mask but missing from your input data.`
- );
- }
-
- if (!fieldMaskContains(validatedFieldPaths, fieldPath)) {
- validatedFieldPaths.push(fieldPath);
- }
- }
-
- fieldMask = new FieldMask(validatedFieldPaths);
- fieldTransforms = context.fieldTransforms.filter(transform =>
- fieldMask!.covers(transform.field)
- );
- } else {
- fieldMask = null;
- fieldTransforms = context.fieldTransforms;
- }
-
- return new ParsedSetData(
- new ObjectValue(updateData),
- fieldMask,
- fieldTransforms
- );
-}
-
 export class DeleteFieldValueImpl extends FieldValue {
  _toFieldTransform(context: ParseContextImpl): null {
  if (context.dataSource === UserDataSource.MergeSet) {

packages/firestore/src/remote/internal_serializer.ts

@@ -102,7 +102,6 @@ export function _internalAggregationQueryToProtoRunAggregationQueryRequest<
  *
  * @param pipeline - The Pipeline to convert to proto representation.
  */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function _internalPipelineToExecutePipelineRequestProto(
  pipeline: Pipeline
  // eslint-disable-next-line @typescript-eslint/no-explicit-any