[AI] Update empty parts check for urlContextMetadata #15355
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow on to #15262 now that urlContext tool support has been added
Summary of Changes
This pull request refines the
isEmptylogic within theCandidatestruct of the Firebase AI SDK. It specifically updates theisEmptycomputed property to account forurlContextMetadata, preventingCandidateobjects from being incorrectly identified as empty when they contain relevant URL context information. This change ensures more accurate content generation responses and is accompanied by new unit tests to validate the updated behavior.Highlights
isEmptycomputed property in theCandidatestruct has been updated to includeurlContextMetadatain its evaluation, ensuring that candidates with this metadata are no longer considered empty.Candidate.isEmptyproperty, specifically covering scenarios whereurlContextMetadatais present or absent.GenerateContentResponseTests.swiftnow uses@testable import FirebaseAIto allow access to internal types for comprehensive testing.Changelog
isEmptycomputed property in theCandidatestruct to includeurlContextMetadatain its check.@testable import FirebaseAIto enable testing of internal types.testCandidateIsEmpty_allEmpty_isTrueandtestCandidateIsEmpty_withURLContextMetadata_isFalse) to thoroughly validate the updatedCandidate.isEmptylogic.Activity
try XCTUnwrapfor robust URL handling in tests.