Skip to content

Conversation

@paulb777
Copy link
Member

#no-changelog

Test for #14671

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code adds a new test case generateContentSchemaItems to verify the minItems and maxItems constraints in the response schema. The test configures a generative model with a schema that specifies an array of city names with a minimum of 3 items and a maximum of 5 items. It then sends a prompt to the model and verifies that the response contains a JSON array with the expected number of cities. Overall, this is a good addition to ensure the proper functioning of the schema validation feature.

Merge Readiness

The code changes introduce a new test case, and the implementation is well-done. I would recommend merging this pull request, but I am unable to directly approve it. Please have others review and approve this code before merging.

@paulb777
Copy link
Member Author

How about allConfigsExceptDeveloperV1? Added in last commit.

@paulb777 paulb777 merged commit 7e20da3 into main Apr 10, 2025
36 checks passed
@paulb777 paulb777 deleted the pb-add-min-max-test branch April 10, 2025 19:43
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants