Skip to content

Correcting UserRecord falsey values to match types in admin sdk (#875) #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correcting UserRecord falsey values to match types in admin sdk (#875) #876

wants to merge 1 commit into from

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Mar 29, 2021

Description

Stop setting these fields in UserRecord to null when they are not present - they should be undefined in that case. Fixes #875, though I am a little worried that this breaks users who were specifically checking if (userRecord.field == null).
@google-cla google-cla bot added the cla: yes label Mar 29, 2021
@joehan joehan mentioned this pull request Mar 29, 2021
Closed
@joehan joehan requested a review from inlined March 29, 2021 19:05
@i14h
Copy link
Member

i14h commented Mar 29, 2021

@karayu what do you think about this issue? the change will be possibly breaking for some users
@inlined
Copy link
Member

inlined commented Apr 6, 2021

  1. IIRC the behavior was explicitly to provide exists-but-falsey behavior, so we should just replace the null with undefined so that iteration still includes those keys (we can revisit if we think this behavior is wrong)
  2. Per offline triage, we cannot fix this until we make a major version bump. Will consider in vNext.
@inlined inlined closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

3 participants

@joehan @i14h @inlined