Cleaning up docgen #871
Merged
Cleaning up docgen #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…s if they dont exist
joehan commented Mar 5, 2021
| // Devsite doesn't like css.map files. | ||
| return fs.unlink(`${docPath}/assets/css/main.css.map`); | ||
| if (fs.existsSync(`${docPath}/assets/css/main.css.map`)) { | ||
| return fs.unlink(`${docPath}/assets/css/main.css.map`); |
There was a problem hiding this comment.
When I run this script, I don't get any css.map file generated by Typedoc, and so the script errors out. It's possible that the correct solution here is just to get rid of this unlink entirely, but I figured this was slightly safer in case I'm missing some reason that css.map would get generated .
There was a problem hiding this comment.
I did some digging and I can't find out why either. LGTM.
inlined approved these changes Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up our docgen script: