- Notifications
You must be signed in to change notification settings - Fork 218
Closed
Labels
api: realtime-databasenode-10tracked internallyIssues that are tracked internally, even though the issue is closedIssues that are tracked internally, even though the issue is closedtype: bug
Description
Related issues
None really.
[REQUIRED] Version info
node:
v10.15.3
firebase-functions:
2.3.0
firebase-tools:
6.10.0
firebase-admin:
7.3.0
[REQUIRED] Test case
Deploy a database trigger on Node 10 runtime and make it run by updating the database.
[REQUIRED] Steps to reproduce
Same as above.
[REQUIRED] Expected behavior
I just tested upgrading our functions from Node 8 to Node 10. I expected the transition to go smoothly.
[REQUIRED] Actual behavior
Everything is working fine locally with firebase-tools@6.10.0 and firebase-functions-test@0.16.0 (which works like a charm ATM, and is way faster than the previous emulator).
Deploying is working great too.
But the functions crash with the following logs:
Function execution took 8021 ms, finished with status: 'error' TypeError: Cannot read property 'name' of undefined at RefBuilder.changeConstructor (/srv/functions/node_modules/firebase-functions/lib/providers/database.js:117:85) at cloudFunctionNewSignature (/srv/functions/node_modules/firebase-functions/lib/cloud-functions.js:119:34) at cloudFunction (/srv/functions/node_modules/firebase-functions/lib/cloud-functions.js:151:20) at Promise.resolve.then (/srv/node_modules/@google-cloud/functions-framework/build/src/invoker.js:330:28) at process._tickCallback (internal/process/next_tick.js:68:7) Were you able to successfully deploy your functions?
Some of our ~60 functions failed to deploy, but not more than the usual number, and not the ones that were tested.
courthead, SiestaMadokaist, ronkot and rootuxcourthead, swabzz and EthanSK
Metadata
Metadata
Assignees
Labels
api: realtime-databasenode-10tracked internallyIssues that are tracked internally, even though the issue is closedIssues that are tracked internally, even though the issue is closedtype: bug