Skip to content

Impose a size limit on payloads sent to DataTransport #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Impose a size limit on payloads sent to DataTransport #1406

merged 1 commit into from
Mar 31, 2020

Conversation

@mrwillis21
Copy link
Contributor

@mrwillis21 mrwillis21 commented Mar 31, 2020

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 31, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020

Coverage Report

Affected SDKs

SDKTypeBase (ad62fcc)Head (69edb09)Diff
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (ad62fcc)Head (69edb09)Diff
firebase-inappmessagingapk (aggressive)601290.00601289.00-1.00 (-0.00%)
protolite-well-known-typesapk (aggressive)122363.00122384.00+21.00 (+0.02%)
firebase-segmentationapk (aggressive)1017144.001017145.00+1.00 (+0.00%)
firebase-storageapk (aggressive)325641.00325635.00-6.00 (-0.00%)
firebase-commonapk (aggressive)82949.0082956.00+7.00 (+0.01%)
firebase-crashlytics-ndkapk (release)1936966.001937145.00+179.00 (+0.01%)
apk (aggressive)1170689.001170899.00+210.00 (+0.02%)
firebase-databaseapk (aggressive)325609.00325606.00-3.00 (-0.00%)
firebase-crashlyticsapk (release)1353912.001354111.00+199.00 (+0.01%)
aar400122.00400620.00+498.00 (+0.12%)
apk (aggressive)584006.00584213.00+207.00 (+0.04%)
firebase-installationsaar55081.0055082.00+1.00 (+0.00%)
apk (aggressive)84600.0084597.00-3.00 (-0.00%)
firebase-dynamic-linksapk (aggressive)327458.00327465.00+7.00 (+0.00%)
firebase-installations-interopapk (aggressive)61714.0061699.00-15.00 (-0.02%)
firebase-abtapk (aggressive)85719.0085702.00-17.00 (-0.02%)
firebase-configapk (aggressive)395831.00395817.00-14.00 (-0.00%)
firebase-inappmessaging-displayapk (aggressive)1603001.001602987.00-14.00 (-0.00%)
firebase-functionsapk (aggressive)393465.00393455.00-10.00 (-0.00%)
firebase-database-collectionapk (aggressive)313622.00313605.00-17.00 (-0.01%)
firebase-firestoreapk (aggressive)443188.00443174.00-14.00 (-0.00%)
Metric Unit: byte

Test Logs
mrichards
mrichards approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@mrwillis21 mrwillis21 merged commit 59e9c3a into master Mar 31, 2020
@mrwillis21 mrwillis21 deleted the crashlytics-limit-report-size branch March 31, 2020 22:50
@firebase firebase locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/M

5 participants

@mrwillis21 @google-oss-bot @mrichards @jakeouellette @googlebot