Skip to content

Fix up Crashlytics javadocs #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix up Crashlytics javadocs #1173

merged 1 commit into from
Jan 29, 2020

Conversation

@mrwillis21
Copy link
Contributor

@mrwillis21 mrwillis21 commented Jan 29, 2020

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jan 29, 2020
@mrwillis21 mrwillis21 requested a review from mrichards January 29, 2020 18:18
@codecov
Copy link

codecov bot commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #1173 into master will decrease coverage by 45.36%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics 7.6% <ø> (-92.4%) 72 <ø> (+72)
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging ? ?
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?
Impacted Files Coverage Δ Complexity Δ
...ogle/firebase/crashlytics/FirebaseCrashlytics.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ase/crashlytics/internal/report/ReportManager.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...tics/internal/stacktrace/TrimmedThrowableData.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...m/google/firebase/crashlytics/internal/Logger.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...e/crashlytics/internal/ndk/ProcMapEntryParser.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...hlytics/internal/stacktrace/MiddleOutStrategy.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...shlytics/internal/settings/SettingsJsonParser.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...s/internal/unity/ResourceUnityVersionProvider.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...gle/firebase/crashlytics/CrashlyticsRegistrar.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ebase/crashlytics/internal/log/LogFileManager.java 62.22% <0%> (ø) 10% <0%> (ø) ⬇️
... and 647 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caac111...b697607. Read the comment docs.
mrichards
mrichards approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar FTW.
@mrwillis21 mrwillis21 merged commit 08af4ed into master Jan 29, 2020
@mrwillis21 mrwillis21 deleted the update-crashlytics-javadocs branch January 29, 2020 18:50
@firebase firebase locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/S

4 participants

@mrwillis21 @mrichards @googlebot @google-oss-bot