Clarify timestamp seconds handling

Author: mrwillis21

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java

@@ -397,7 +397,7 @@ public Task<Void> call() throws Exception {
  // We've fatally crashed, so write the marker file that indicates a crash occurred.
  crashMarker.create();
 
- long timestampSeconds = time.getTime() / 1000;
+ long timestampSeconds = getTimestampSeconds(time);
  reportingCoordinator.persistFatalEvent(ex, thread, timestampSeconds);
  writeFatal(thread, ex, timestampSeconds);
 
@@ -648,7 +648,7 @@ void writeNonFatalException(final Thread thread, final Throwable ex) {
  @Override
  public void run() {
  if (!isHandlingException()) {
- long timestampSeconds = time.getTime() / 1000;
+ long timestampSeconds = getTimestampSeconds(time);
  reportingCoordinator.persistNonFatalEvent(ex, thread, timestampSeconds);
  doWriteNonFatal(thread, ex, timestampSeconds);
  }
@@ -802,7 +802,7 @@ boolean finalizeSessions(int maxCustomExceptionEvents) {
  * class.
  */
  private void doOpenSession() throws Exception {
- final long startedAtSeconds = new Date().getTime() / 1000;
+ final long startedAtSeconds = getCurrentTimestampSeconds();
  final String sessionIdentifier = new CLSUUID(idManager).toString();
 
  Logger.getLogger().d("Opening a new session with ID " + sessionIdentifier);
@@ -860,7 +860,7 @@ private void doCloseSessions(int maxCustomExceptionEvents, boolean includeCurren
 
  closeOpenSessions(sessionBeginFiles, offset, maxCustomExceptionEvents);
 
- reportingCoordinator.finalizeSessions(new Date().getTime() / 1000);
+ reportingCoordinator.finalizeSessions(getCurrentTimestampSeconds());
  }
 
  /**
@@ -1196,6 +1196,14 @@ private static void gzip(@NonNull byte[] bytes, @NonNull File path) throws IOExc
  }
  }
 
+ private static long getCurrentTimestampSeconds() {
+ return getTimestampSeconds(new Date());
+ }
+
+ private static long getTimestampSeconds(Date date) {
+ return date.getTime() / 1000;
+ }
+
  /** Removes dashes in the Crashlytics session identifier to conform to Firebase constraints. */
  private static String makeFirebaseSessionIdentifier(String sessionIdentifier) {
  return sessionIdentifier.replaceAll("-", "");
@@ -1586,7 +1594,7 @@ private void synthesizeSessionFile(
  Logger.getLogger().d("Collecting SessionStart data for session ID " + sessionId);
  writeToCosFromFile(cos, sessionBeginFile);
 
- cos.writeUInt64(4, new Date().getTime() / 1000);
+ cos.writeUInt64(4, getCurrentTimestampSeconds());
  cos.writeBool(5, hasFatal);
 
  cos.writeUInt32(11, ANALYZER_VERSION);