Accept :service_log_path for Chrome in Ruby. Fixes issue 3475.

Author: jarib

rb/lib/selenium/webdriver/chrome/bridge.rb

@@ -11,7 +11,7 @@ def initialize(opts = {})
  if opts.has_key?(:url)
  url = opts.delete(:url)
  else
- @service = Service.default_service
+ @service = Service.default_service(*extract_service_args(opts))
  @service.start
 
  url = @service.uri
@@ -102,6 +102,16 @@ def create_capabilities(opts)
  caps
  end
 
+ def extract_service_args(opts)
+ args = []
+
+ if opts.has_key?(:service_log_path)
+ args << "--log-path=#{opts.delete(:service_log_path)}"
+ end
+
+ args
+ end
+
  end # Bridge
  end # Chrome
  end # WebDriver

rb/lib/selenium/webdriver/chrome/service.rb

@@ -29,13 +29,13 @@ def self.executable_path=(path)
  @executable_path = path
  end
 
- def self.default_service
- new executable_path, PortProber.above(DEFAULT_PORT)
+ def self.default_service(*extra_args)
+ new executable_path, PortProber.above(DEFAULT_PORT), *extra_args
  end
 
- def initialize(executable_path, port)
+ def initialize(executable_path, port, *extra_args)
  @uri = URI.parse "http://#{Platform.localhost}:#{port}"
- server_command = [executable_path, "--port=#{port}"]
+ server_command = [executable_path, "--port=#{port}", *extra_args]
 
  @process = ChildProcess.build(*server_command)
  @socket_poller = SocketPoller.new Platform.localhost, port, START_TIMEOUT

rb/spec/unit/selenium/webdriver/chrome/bridge_spec.rb

@@ -117,6 +117,11 @@ module Chrome
 
  Bridge.new(:http_client => http, :desired_capabilities => custom_caps, :args => %w[baz])
  end
+
+ it 'accepts :service_log_path' do
+ Service.should_receive(:default_service).with("--log-path=/foo/bar")
+ Bridge.new(:http_client => http, :service_log_path => "/foo/bar")
+ end
  end
 
  end # Chrome