fix: ensure we throw an error if FastlyBody.prototype.read is called with a value which is not coercible to a finite positive integer #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JakeChampion force-pushed the jake/chunk branch 5 times, most recently from 0e88fd6 to b060211 Compare 
guybedford reviewed Jul 31, 2024
JakeChampion force-pushed the jake/chunk branch 2 times, most recently from ae31b9e to b762575 Compare JakeChampion changed the title guybedford approved these changes Aug 2, 2024
| MSG_DEF(JSMSG_TEXT_DECODER_DECODE_OPTIONS_NOT_DICTIONARY, 0, JSEXN_TYPEERR, "TextDecoder.decode: options argument can't be converted to a dictionary.") | ||
| MSG_DEF(JSMSG_TEXT_ENCODER_ENCODEINTO_INVALID_ARRAY, 0, JSEXN_TYPEERR, "TextEncoder.encodeInto: Argument 2 does not implement interface Uint8Array.") | ||
| MSG_DEF(JSMSG_SIMPLE_CACHE_SET_CONTENT_STREAM, 0, JSEXN_TYPEERR, "Content-provided streams are not yet supported for streaming into SimpleCache") | ||
| MSG_DEF(JSMSG_BODY_APPEND_CONTENT_STREAM, 0, JSEXN_TYPEERR, "Content-provided streams are not yet supported for appending onto a FastlyBody") |
There was a problem hiding this comment.
Do we have a list of the cases that we have marked as "not yet" types of errors? Ideally we should carefully track these todos.
JakeChampion force-pushed the jake/chunk branch 3 times, most recently from 68a2a0e to 91ad626 Compare 
JakeChampion commented Aug 5, 2024
JakeChampion commented Aug 5, 2024
JakeChampion commented Aug 5, 2024
JakeChampion commented Aug 5, 2024
JakeChampion force-pushed the jake/chunk branch 2 times, most recently from ac461fa to 10fedae Compare …with a value which is not coercible to a finite positive integer
JakeChampion force-pushed the jake/chunk branch from ebc4eed to 4d595b7 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.