fix: ready-based immediate task indexing #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| CI is currently failing because the Since this is critical fix I'm going ahead with the release based on local & viceroy tests passing and the changes for this release being fully isolated to this subsystem. |
| Thanks for this fix! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes a bug found by @harmony7 in https://github.com/harmony7/compute-react19-readablestream-repro where a specific setup in async tasks with immediate timers would lead to a panic.
The panic in this case turns out to be in the Fastly event loop layer, where I previously implemented a bug in the optimized immediate handle checking case in not properly looking up the immediate index. The logic fix is self-explanatory for the most part.
Confirmed that with this change the linked repo no longer panics.