Skip to content

Add TypeScript #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Add TypeScript #46

merged 1 commit into from
Apr 22, 2020

Conversation

@ifaisalalam
Copy link
Contributor

@ifaisalalam ifaisalalam commented Apr 22, 2020 •
edited
Loading

Fix failing tests in #39

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct
@ifaisalalam ifaisalalam changed the title Ifaisalalam/typings fix Add TypeScript Apr 22, 2020
@ifaisalalam
Copy link
Contributor Author

ifaisalalam commented Apr 22, 2020

I am fixing typings to allow developers to use other Redis client libraries. Also adding TS support on namespaces.
mcollina
mcollina approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@mcollina mcollina merged commit 2e907df into fastify:master Apr 22, 2020
@ifaisalalam ifaisalalam deleted the ifaisalalam/typings-fix branch April 22, 2020 22:01
@ifaisalalam ifaisalalam mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ifaisalalam @mcollina