do not quit given client on close #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cemremengu approved these changes Dec 29, 2018
README.md Outdated
| You may also supply an existing *Redis* client instance by passing an options | ||
| object with the `client` property set to the instance. | ||
| object with the `client` property set to the instance. In this case, | ||
| the client is not automatically close when the Fastify instance is |
cemremengu approved these changes Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR aligns the behavior of fastify-redis with the others database driver. If a client is passed in, then it will not be closed. This speeds up tests significantly because we won’t have to recreate that many connections.