Skip to content

Conversation

@nhajidin
Copy link
Contributor

@nhajidin nhajidin commented Nov 7, 2016

Fixes #949

@fson
Copy link
Contributor

fson commented Nov 17, 2016

Thanks for the pull request @nhajidin! Can you describe the steps you followed to check that this works correctly?

@nhajidin
Copy link
Contributor Author

I did the following:

  1. Run create-react-app issue-949
  2. Add a .babelrc file with { "presets": ["es2015"] }
  3. Run cd issue-949
  4. Run npm test; the test will fail
  5. Edit file node_modules\react-scripts\config\jest\transform.js to include babelrc: false
  6. Run npm test; the test will now pass
@fson fson added this to the 0.8.0 milestone Nov 20, 2016
@fson fson merged commit a5c30b9 into facebook:master Nov 20, 2016
@fson
Copy link
Contributor

fson commented Nov 20, 2016

Thanks!

@nhajidin nhajidin deleted the fix-jest-babelrc branch November 20, 2016 20:32
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.