Remove bundler setup (#4935)

Summary: This PR removes the bundler setup for all of the npm packages in this repo, as discussed with captbaritone in [Discord](https://discord.com/channels/625400653321076807/1342499490011025460/1346175975628734494). While this wouldn't affect the vast majority of use cases, I believe it should technically be considered a breaking change, as it breaks CDN usages and direct CJS requires pointing at outputs. Pull Request resolved: #4935 Reviewed By: tyao1 Differential Revision: D70794723 Pulled By: captbaritone fbshipit-source-id: a4110cf14da26d81995f89a55e3b19c1c2abab32

Author: XiNiHa

gulpfile.js

@@ -33,12 +33,8 @@ const del = require('del');
 const fs = require('fs');
 const gulp = require('gulp');
 const babel = require('gulp-babel');
-const header = require('gulp-header');
 const rename = require('gulp-rename');
-const gulpUtil = require('gulp-util');
 const path = require('path');
-const webpack = require('webpack');
-const webpackStream = require('webpack-stream');
 
 const RELEASE_COMMIT_SHA = process.env.RELEASE_COMMIT_SHA;
 if (RELEASE_COMMIT_SHA && RELEASE_COMMIT_SHA.length !== 40) {
@@ -52,10 +48,6 @@ const VERSION = RELEASE_COMMIT_SHA
  ? `0.0.0-main-${RELEASE_COMMIT_SHA.substr(0, 8)}`
  : process.env.npm_package_version;
 
-const DEVELOPMENT_HEADER = `/**
- * Relay v${VERSION}
- */
-`;
 const PRODUCTION_HEADER = `/**
  * Relay v${VERSION}
  *
@@ -66,39 +58,6 @@ const PRODUCTION_HEADER = `/**
  */
 `;
 
-const buildDist = function (filename, opts, isProduction) {
- const webpackOpts = {
- externals: [/^[-/a-zA-Z0-9]+$/, /^@babel\/.+$/],
- target: opts.target,
- output: {
- filename: filename,
- libraryTarget: opts.libraryTarget,
- library: opts.libraryName,
- },
- plugins: [
- new webpack.DefinePlugin({
- 'process.env.NODE_ENV': JSON.stringify(
- isProduction ? 'production' : 'development',
- ),
- }),
- ],
- };
- if (isProduction && !opts.noMinify) {
- // See more chunks configuration here: https://gist.github.com/sokra/1522d586b8e5c0f5072d7565c2bee693
- webpackOpts.optimization = {
- minimize: true,
- };
- }
- return webpackStream(webpackOpts, webpack, function (err, stats) {
- if (err) {
- throw new gulpUtil.PluginError('webpack', err);
- }
- if (stats.compilation.errors.length) {
- throw new gulpUtil.PluginError('webpack', stats.toString());
- }
- });
-};
-
 // Paths from package-root
 const PACKAGES = 'packages';
 const DIST = 'dist';
@@ -119,15 +78,6 @@ const builds = [
  index: 'BabelPluginRelay.js',
  macro: 'BabelPluginRelay.macro.js',
  },
- bundles: [
- {
- entry: 'BabelPluginRelay.js',
- output: 'babel-plugin-relay',
- libraryName: 'BabelPluginRelay',
- libraryTarget: 'commonjs2',
- target: 'node',
- },
- ],
  },
  {
  package: 'react-relay',
@@ -137,79 +87,25 @@ const builds = [
  legacy: 'legacy.js',
  ReactRelayContext: 'ReactRelayContext.js',
  },
- bundles: [
- {
- entry: 'index.js',
- output: 'react-relay',
- libraryName: 'ReactRelay',
- libraryTarget: 'umd',
- },
- {
- entry: 'hooks.js',
- output: 'react-relay-hooks',
- libraryName: 'ReactRelayHooks',
- libraryTarget: 'umd',
- },
- {
- entry: 'legacy.js',
- output: 'react-relay-legacy',
- libraryName: 'ReactRelayLegacy',
- libraryTarget: 'umd',
- },
- ],
  },
  {
  package: 'relay-runtime',
  exports: {
  index: 'index.js',
  experimental: 'experimental.js',
  },
- bundles: [
- {
- entry: 'index.js',
- output: 'relay-runtime',
- libraryName: 'RelayRuntime',
- libraryTarget: 'umd',
- },
- {
- entry: 'experimental.js',
- output: 'relay-runtime-experimental',
- libraryName: 'ReactRelayExperimental',
- libraryTarget: 'umd',
- },
- ],
  },
  {
  package: 'relay-test-utils',
  exports: {
  index: 'index.js',
  },
- bundles: [
- {
- entry: 'index.js',
- output: 'relay-test-utils',
- libraryName: 'RelayTestUtils',
- libraryTarget: 'commonjs2',
- target: 'node',
- noMinify: true, // Note: uglify can't yet handle modern JS
- },
- ],
  },
  {
  package: 'relay-test-utils-internal',
  exports: {
  index: 'index.js',
  },
- bundles: [
- {
- entry: 'index.js',
- output: 'relay-test-utils-internal',
- libraryName: 'RelayTestUtilsInternal',
- libraryTarget: 'commonjs2',
- target: 'node',
- noMinify: true, // Note: uglify can't yet handle modern JS
- },
- ],
  },
 ];
 
@@ -295,40 +191,8 @@ const exportsFiles = gulp.series(
  ),
 );
 
-const bundlesTasks = [];
-builds.forEach(build => {
- build.bundles.forEach(bundle => {
- bundlesTasks.push(function bundleTask() {
- return gulp
- .src(path.join(DIST, build.package, 'lib', bundle.entry))
- .pipe(
- buildDist(bundle.output + '.js', bundle, /* isProduction */ false),
- )
- .pipe(header(DEVELOPMENT_HEADER))
- .pipe(gulp.dest(path.join(DIST, build.package)));
- });
- });
-});
-const bundles = gulp.series(bundlesTasks);
-
-const bundlesMinTasks = [];
-builds.forEach(build => {
- build.bundles.forEach(bundle => {
- bundlesMinTasks.push(function bundlesMinTask() {
- return gulp
- .src(path.join(DIST, build.package, 'lib', bundle.entry))
- .pipe(
- buildDist(bundle.output + '.min.js', bundle, /* isProduction */ true),
- )
- .pipe(header(PRODUCTION_HEADER))
- .pipe(gulp.dest(path.join(DIST, build.package)));
- });
- });
-});
-const bundlesMin = gulp.series(bundlesMinTasks);
-
 const clean = () => del(DIST);
-const dist = gulp.series(exportsFiles, bundles, bundlesMin);
+const dist = gulp.series(exportsFiles);
 const watch = gulp.series(dist, () =>
  gulp.watch(INCLUDE_GLOBS, {cwd: PACKAGES}, dist),
 );

package.json

@@ -66,9 +66,7 @@
  "gulp": "4.0.2",
  "gulp-babel": "8.0.0",
  "gulp-chmod": "3.0.0",
- "gulp-header": "2.0.9",
  "gulp-rename": "^2.0.0",
- "gulp-util": "3.0.8",
  "hermes-eslint": "0.25.1",
  "invariant": "^2.2.4",
  "jest": "^29.7.0",
@@ -80,9 +78,7 @@
  "react": "0.0.0-experimental-7670501b-20241124",
  "react-dom": "0.0.0-experimental-7670501b-20241124",
  "react-refresh": "0.0.0-experimental-7670501b-20241124",
- "react-test-renderer": "0.0.0-experimental-7670501b-20241124",
- "webpack": "^5.89.0",
- "webpack-stream": "^7.0.0"
+ "react-test-renderer": "0.0.0-experimental-7670501b-20241124"
  },
  "resolutions": {
  "glob-watcher": "^6.0.0"