Fix routing requests without method

Author: dougwilson

History.md

@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+ * Fix routing requests without method
  * deps: body-parser@1.20.2
  - Fix strict json error message on Node.js 19+
  - deps: content-type@~1.0.5

lib/router/route.js

@@ -60,7 +60,10 @@ Route.prototype._handles_method = function _handles_method(method) {
  return true;
  }
 
- var name = method.toLowerCase();
+ // normalize name
+ var name = typeof method === 'string'
+ ? method.toLowerCase()
+ : method
 
  if (name === 'head' && !this.methods['head']) {
  name = 'get';
@@ -103,8 +106,10 @@ Route.prototype.dispatch = function dispatch(req, res, done) {
  if (stack.length === 0) {
  return done();
  }
+ var method = typeof req.method === 'string'
+ ? req.method.toLowerCase()
+ : req.method
 
- var method = req.method.toLowerCase();
  if (method === 'head' && !this.methods['head']) {
  method = 'get';
  }

test/Router.js

@@ -61,6 +61,33 @@ describe('Router', function(){
  router.handle({ method: 'GET' }, {}, done)
  })
 
+ it('handle missing method', function (done) {
+ var all = false
+ var router = new Router()
+ var route = router.route('/foo')
+ var use = false
+
+ route.post(function (req, res, next) { next(new Error('should not run')) })
+ route.all(function (req, res, next) {
+ all = true
+ next()
+ })
+ route.get(function (req, res, next) { next(new Error('should not run')) })
+
+ router.get('/foo', function (req, res, next) { next(new Error('should not run')) })
+ router.use(function (req, res, next) {
+ use = true
+ next()
+ })
+
+ router.handle({ url: '/foo' }, {}, function (err) {
+ if (err) return done(err)
+ assert.ok(all)
+ assert.ok(use)
+ done()
+ })
+ })
+
  it('should not stack overflow with many registered routes', function(done){
  this.timeout(5000) // long-running test