Skip to content

Conversation

@Envek
Copy link
Member

@Envek Envek commented Feb 15, 2021

Instead of manual building and pushing of every Docker container on my local machine, as I did before.

Build but not push docker images for pull requests (kind of smoke testing).

Setup (must be done before merging)
Get some credentials for Quay at Settings page → “CLI Password” and store them as Repository secrets called QUAY_USERNAME and QUAY_PASSWORD.

Caching impact

  • First run: job duration from 43 to 52 seconds. Workflow run
  • Second run: job duration from 17 to 59 seconds. Workflow run. 25-30 seconds speed up for “Docker build” step in case of cache hit.
@Envek Envek self-assigned this Feb 15, 2021
@Envek Envek merged commit 2d30cef into master Feb 15, 2021
@Envek Envek deleted the chore/github-actions branch February 15, 2021 17:14
quay.io/evl.ms/fullstaq-ruby:${{ matrix.ruby-version }}-${{ matrix.ruby-variant }}-${{ matrix.debian-image }}
${{ matrix.aliases }}
cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why you guys don't do the cache dance with the run of the mv new_cache_location established_cache_location, as suggested in the official documentation - and even in your articles (note: I realise this PR predates the article, but since it does so by only one month, I assume the article to still be relevant)(?)
(asking because I'm genuinely curious if there's something else at play here that make the use of that workaround irrelevant)
@Envek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants