This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Use CLI scripts from ethereumjs-config in package.json #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
s1na approved these changes Jan 29, 2019
Contributor
s1na left a comment
s1na left a comment There was a problem hiding this comment.
Nice! Tested locally, works well!
Member Author
| Addressed this in ethereumjs/ethereumjs-config#17. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ok, wanted to do this short-term PR to have some more confirmation that the new CLI commands actually works, they do. 😄
Realized now with some more distant look that it would be good to have the original command exposed, currently only the command name from config is displayed (before/after):
Will directly address in a short PR on config.