Skip to content

Fix eoftest to run all tests from a JSON file #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chfast merged 1 commit into from
Jun 25, 2024
Merged

Fix eoftest to run all tests from a JSON file #935

chfast merged 1 commit into from
Jun 25, 2024

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Jun 25, 2024

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (17ec114) to head (28c7a54).

❗ Current head 28c7a54 differs from pull request most recent head 5d77ab7

Please upload reports for the commit 5d77ab7 to get more accurate results.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #935 +/- ## ======================================= Coverage 95.12% 95.12% ======================================= Files 140 140 Lines 15885 15888 +3 ======================================= + Hits 15110 15113 +3  Misses 775 775
Flag Coverage Δ
eof_execution_spec_tests 16.60% <100.00%> (+0.24%) ⬆️
ethereum_tests 26.91% <100.00%> (+0.03%) ⬆️
ethereum_tests_silkpre 18.35% <0.00%> (-0.01%) ⬇️
execution_spec_tests 17.82% <0.00%> (-0.01%) ⬇️
unittests 90.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/eoftest/eoftest_runner.cpp 87.50% <100.00%> (+2.65%) ⬆️

... and 1 file with indirect coverage changes
@pdobacz pdobacz requested a review from gumb0 June 25, 2024 12:10
@pdobacz pdobacz self-assigned this Jun 25, 2024
@chfast chfast changed the title Fix eoftest_runner to run all tests from file Fix eofparse to run all tests from a JSON file Jun 25, 2024
@chfast chfast added EOF tests Testing infrastructure labels Jun 25, 2024
@chfast chfast changed the title Fix eofparse to run all tests from a JSON file Fix eoftest to run all tests from a JSON file Jun 25, 2024
@chfast
Copy link
Member

chfast commented Jun 25, 2024

This bumps eof.cpp coverage via EOF/EEST tests from ~74% to ~80%.
@chfast chfast enabled auto-merge (squash) June 25, 2024 18:19
@chfast chfast merged commit 9be04a5 into master Jun 25, 2024
@chfast chfast deleted the fix-eoftest branch June 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EOF tests Testing infrastructure

3 participants

@pdobacz @chfast