test: Introduce TestState and TestAccount #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #811 +/- ## ======================================= Coverage 95.14% 95.15% ======================================= Files 138 140 +2 Lines 15766 15785 +19 ======================================= + Hits 15001 15020 +19 Misses 765 765
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast force-pushed the test/test_account branch 2 times, most recently from 78d4e78 to 9aa80be Compare chfast force-pushed the test/test_account branch 2 times, most recently from 43616e1 to 7b5c45d Compare 
chfast commented Jun 4, 2024
pdobacz approved these changes Jun 4, 2024
Member
pdobacz left a comment
pdobacz left a comment There was a problem hiding this comment.
2 items to look at, otherwise makes sense to me
test/unittests/state_transition.cpp Outdated
| // Find unexpected storage keys. This will also report entries with value 0. | ||
| EXPECT_TRUE(expected_acc.storage.contains(key)) | ||
| << "unexpected storage key " << key << "=" << value.current << " in " << addr; | ||
| // FIXME: |
Member
There was a problem hiding this comment.
is this fixme ok to be left behind? I'm staring at this and can't seem to figure it out, pls check
Member Author
There was a problem hiding this comment.
No. I need to figure it out. This code has been changed since the start of this PR. The new types makes the comparison easier (e.g. TestState{} == TestState{}) but we also want to have rich failure comments.
This decouples the `state::State` for transaction execution from the state object for test definitions and asserts. The `state::State` (also called "intra state") has some constructs and data related to transaction execution only (like "current" and "original" storage values). These should not be exposed to tests and make test definitions more complicated. This separation should also help with adding new public API for EVM with transaction-level execution granularity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This decouples the
state::Statefor transaction execution from the state object for test definitions and asserts.The
state::State(also called "intra state") has some constructs and data related to transaction execution only (like "current" and "original" storage values). These should not be exposed to tests and make test definitions more complicated.This separation should also help with adding new public API for EVM with transaction-level execution granularity.