Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Aug 21, 2023

Implement State Journal: a list of changes made to the state
and implement state reverting as undoing the changes until the given
journal checkpoint.

With the State Journal the backup copy of the state is no longer
performed and the memory addresses of the accounts are not changing
during execution. This allows us to avoid some copies and lookups.

@codecov
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #689 (658ede9) into master (1a3d582) will decrease coverage by 0.01%.
The diff coverage is 98.85%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #689 +/- ## ========================================== - Coverage 97.87% 97.87% -0.01%  ========================================== Files 110 110 Lines 10402 10473 +71 ========================================== + Hits 10181 10250 +69  - Misses 221 223 +2 
Flag Coverage Δ
blockchaintests ?
statetests 62.37% <100.00%> (+0.80%) ⬆️
statetests-silkpre 26.43% <90.12%> (+0.46%) ⬆️
unittests 95.85% <86.20%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/state.cpp 100.00% <100.00%> (ø)
test/state/state.hpp 100.00% <100.00%> (ø)
test/state/host.cpp 94.16% <97.56%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

@chfast chfast force-pushed the state_journal branch 2 times, most recently from 084699b to 50c9207 Compare December 13, 2023 15:12
@chfast chfast changed the title Implement State Journal state: Revert state changes with journal Dec 13, 2023
@chfast chfast marked this pull request as ready for review December 13, 2023 18:05
Implement State Journal: a list of changes made to the state and implement state reverting as undoing the changes until the given journal checkpoint.
With the State Journal the backup copy of the state is no longer performed and the memory addresses of the accounts are not changing during execution. This allows us to avoid some copies and lookups.
@chfast chfast merged commit c531a92 into master Dec 19, 2023
@chfast chfast deleted the state_journal branch December 19, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants