Skip to content

Load BlockInfo fixes required by exec-spec-tests #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodiazet merged 3 commits into from
Mar 27, 2023
Merged

Load BlockInfo fixes required by exec-spec-tests #583

rodiazet merged 3 commits into from
Mar 27, 2023

Conversation

@rodiazet
Copy link
Member

@rodiazet rodiazet commented Mar 15, 2023 •
edited
Loading

-Add tests cases for BlockInfo loader according to bugs reported.
-Extend from_json implementation for 64 bits integers to support hex and dec strings and values
-Add special case handling to suport currentRandom passed as 0. execution-spec-tests requires it.
@rodiazet rodiazet requested a review from chfast March 15, 2023 19:59
chfast
chfast reviewed Mar 15, 2023
View reviewed changes
@rodiazet rodiazet changed the title BlockInfo loader unit test Load BlockInfo fixes required by exec-spec-tests Mar 21, 2023
@rodiazet rodiazet requested a review from chfast March 21, 2023 11:31
@rodiazet rodiazet force-pushed the bi-load-test branch 2 times, most recently from 7bd0c5a to bd4a899 Compare March 21, 2023 12:08
chfast
chfast reviewed Mar 21, 2023
View reviewed changes
axic
axic reviewed Mar 21, 2023
View reviewed changes
@rodiazet rodiazet force-pushed the bi-load-test branch 2 times, most recently from 14e3c7b to 134866b Compare March 21, 2023 14:12
@rodiazet rodiazet requested review from axic and chfast March 21, 2023 14:12
@chfast chfast force-pushed the bi-load-test branch 2 times, most recently from c75ad06 to be80c7d Compare March 27, 2023 11:10
@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Merging #583 (5668214) into master (dd1b623) will increase coverage by 0.21%.
The diff coverage is 99.03%.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #583 +/- ## ========================================== + Coverage 96.85% 97.07% +0.21%  ========================================== Files 73 74 +1 Lines 7276 7375 +99 ========================================== + Hits 7047 7159 +112  + Misses 229 216 -13
Flag Coverage Δ
blockchaintests 63.71% <ø> (ø)
statetests 63.11% <70.00%> (+0.01%) ⬆️
unittests 93.88% <99.03%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/unittests/statetest_loader_tx_test.cpp 100.00% <ø> (ø)
test/statetest/statetest_loader.cpp 87.86% <96.00%> (+8.51%) ⬆️
...est/unittests/statetest_loader_block_info_test.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)
@rodiazet rodiazet merged commit fd99568 into master Mar 27, 2023
@rodiazet rodiazet deleted the bi-load-test branch March 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@rodiazet @axic @chfast