state: Refactor compute_new_account_address() #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chfast force-pushed the new_account_address branch from a9f62c4 to 01a1671 Compare 
Refactor `compute_new_account_address()` to match Yellow Paper ππππ. This makes it a separate utility independent of `evmc_message`.
chfast force-pushed the new_account_address branch from 01a1671 to bd35f8f Compare 
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## master #575 +/- ## ========================================== + Coverage 97.06% 97.13% +0.07% ========================================== Files 71 72 +1 Lines 6545 6571 +26 ========================================== + Hits 6353 6383 +30 + Misses 192 188 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic reviewed Feb 27, 2023
| /// @param salt The salt for CREATE2. If null, CREATE address is computed. YP: ΞΆ. | ||
| /// @param init_code The contract creation init code. Value only affects CREATE2. YP: π’. | ||
| /// @return The computed address for CREATE or CREATE2 scheme. | ||
| address compute_new_account_address(const address& sender, uint64_t sender_nonce, |
Member
There was a problem hiding this comment.
Why not have two overloads:
address compute_new_account_address(const evmc_message& msg, uint64_t sender_nonce) noexcept; address compute_new_account_address(const address& sender, bytes32& salt, bytes_view init_code) noexcept; The sender_nonce is irrelevant for create2 and this separation makes it clear which values are used in which.
Member Author
There was a problem hiding this comment.
Mostly so that a user don't need to know which overload to select. Now it only needs to provide arguments (sometimes redundantly) and will get the right answer. Non-functional change from what we had.
Member
There was a problem hiding this comment.
I think it still makes sense to separate and I'd aim for that later, but it is debatable.
axic approved these changes Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refactor
compute_new_account_address()to match ππππ from Yellow Paper.This makes it a separate utility independent of
evmc_message.