feat: Fixed variants of ClassRangesCharacterClassElement #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ota-meshi changed the title ClassRangesCharacterClassElementClassRangesCharacterClassElement 
| 🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #121
This PR changes the type of
ClassRangesCharacterClassElementto not include properties of strings. See #121 for details.The new type caused a type error in the
RegExpParserState#onUnicodePropertyCharacterSet. TypeScript was unable to prove that noStringsUnicodePropertyCharacterSetwas added to aClassRangesCharacterClass. So I changed the parser to fix this type error. I intentionally did not use type casts, so that TypeScript can statically prove that the parser creates a correct AST.