Extract out logging functionality.

Author: ioquatix

lib/rubydns/extensions/logger.rb

@@ -0,0 +1,30 @@
+# Copyright (c) 2009, 2011 Samuel G. D. Williams. <http://www.oriontransfer.co.nz>
+# 
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+# 
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+# 
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+
+module RubyDNS
+# Logs an exception nicely.
+def self.log_exception(logger, exception)
+logger.error "#{exception.class}: #{exception.message}"
+if exception.backtrace
+Array(exception.backtrace).each { |at| logger.error at }
+end
+
+end
+end

lib/rubydns/server.rb

@@ -19,6 +19,7 @@
 # THE SOFTWARE.
 
 require 'rubydns/transaction'
+require 'rubydns/extensions/logger'
 
 module RubyDNS
 
@@ -213,10 +214,7 @@ def process_query(query, options = {}, &block)
 transaction.errback do |response|
 if Exception === response
 @logger.error "Exception thrown while processing #{transaction}!"
-@logger.error "#{response.class}: #{response.message}"
-if response.backtrace
-Array(response.backtrace).each { |at| @logger.error at }
-end
+RubyDNS.log_exception(@logger, response)
 else
 @logger.error "Failure while processing #{transaction}!"
 @logger.error "#{response.inspect}"