fix showStartPage setting on configSettings.ts (microsoft#13706)

* fix showStartPage setting on configSettings.ts * add news file * Fix unit tests * oops

Author: David Kutugata

news/2 Fixes/13706.md

@@ -0,0 +1 @@
+Fix the behavior of the 'python.showStartPage' setting.

src/client/common/configSettings.ts

@@ -544,6 +544,11 @@ export class PythonSettings implements IPythonSettings {
  this.datascience = dataScienceSettings;
  }
 
+ const showStartPage = pythonSettings.get<boolean>('showStartPage');
+ if (showStartPage !== undefined) {
+ this.showStartPage = showStartPage;
+ }
+
  this.insidersChannel = pythonSettings.get<ExtensionChannels>('insidersChannel')!;
  }
 

src/test/common/configSettings/configSettings.unit.test.ts

@@ -47,7 +47,7 @@ suite('Python Settings', async () => {
  let settings: CustomPythonSettings;
  setup(() => {
  sinon.stub(EnvFileTelemetry, 'sendSettingTelemetry').returns();
- config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Strict);
+ config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Loose);
  expected = new CustomPythonSettings(undefined, new MockAutoSelectionService());
  settings = new CustomPythonSettings(undefined, new MockAutoSelectionService());
  expected.defaultInterpreterPath = 'python';