Up idle timeout to match launch timeout (nightly flake failure) (microsoft#13753)

* Up idle timeout to match launch timeout. Test was really close to 30 secs so it failed * Up launch time out

Author: rchiodo

src/client/datascience/jupyter/jupyterSession.ts

@@ -37,7 +37,8 @@ export class JupyterSession extends BaseJupyterSession {
  private readonly outputChannel: IOutputChannel,
  private readonly restartSessionCreated: (id: Kernel.IKernelConnection) => void,
  restartSessionUsed: (id: Kernel.IKernelConnection) => void,
- readonly workingDirectory: string
+ readonly workingDirectory: string,
+ private readonly idleTimeout: number
  ) {
  super(restartSessionUsed, workingDirectory);
  this.kernelConnectionMetadata = kernelSpec;
@@ -106,15 +107,14 @@ export class JupyterSession extends BaseJupyterSession {
  if (!session || !this.contentsManager || !this.sessionManager) {
  throw new Error(localize.DataScience.sessionDisposed());
  }
-
  let result: ISessionWithSocket | undefined;
  let tryCount = 0;
  // tslint:disable-next-line: no-any
  let exception: any;
  while (tryCount < 3) {
  try {
  result = await this.createSession(session.serverSettings, kernelConnection, cancelToken);
- await this.waitForIdleOnSession(result, 30000);
+ await this.waitForIdleOnSession(result, this.idleTimeout);
  this.restartSessionCreated(result.kernel);
  return result;
  } catch (exc) {

src/client/datascience/jupyter/jupyterSessionManager.ts

@@ -182,7 +182,8 @@ export class JupyterSessionManager implements IJupyterSessionManager {
  this.outputChannel,
  this.restartSessionCreatedEvent.fire.bind(this.restartSessionCreatedEvent),
  this.restartSessionUsedEvent.fire.bind(this.restartSessionUsedEvent),
- workingDirectory
+ workingDirectory,
+ this.configService.getSettings().datascience.jupyterLaunchTimeout
  );
  try {
  await session.connect(this.configService.getSettings().datascience.jupyterLaunchTimeout, cancelToken);

src/test/datascience/dataScienceIocContainer.ts

@@ -1419,7 +1419,7 @@ export class DataScienceIocContainer extends UnitTestIocContainer {
  pythonSettings.datascience = {
  allowImportFromNotebook: true,
  alwaysTrustNotebooks: true,
- jupyterLaunchTimeout: 60000,
+ jupyterLaunchTimeout: 120000,
  jupyterLaunchRetries: 3,
  enabled: true,
  jupyterServerURI: 'local',

src/test/datascience/jupyter/jupyterSession.unit.test.ts

@@ -95,7 +95,8 @@ suite('DataScience - JupyterSession', () => {
  () => {
  restartSessionUsedEvent.resolve();
  },
- ''
+ '',
+ 60_000
  );
  });