Merge branch 'main' into all-contributors/add-kabrunko-dev

Author: tomalaforge

.all-contributorsrc

@@ -26,9 +26,9 @@
  "symbol": "🇵🇹",
  "description": "Translate in Portuguese"
  },
- "translation-pt-BR": {
- "symbol": "🇧🇷",
- "description": "Translate in Brazilian Portuguese"
+ "translation-ru": {
+ "symbol": "🇷🇺",
+ "description": "Translate in Russian"
  }
  },
  "contributors": [
@@ -47,6 +47,38 @@
  "translation-fr"
  ]
  },
+ {
+ "login": "jdegand",
+ "name": "J. Degand",
+ "avatar_url": "https://avatars.githubusercontent.com/u/70610011?v=4",
+ "profile": "https://github.com/jdegand",
+ "contributions": [
+ "doc",
+ "content",
+ "code"
+ ]
+ },
+ {
+ "login": "DeveshChau",
+ "name": "Devesh Chaudhari",
+ "avatar_url": "https://avatars.githubusercontent.com/u/9509673?v=4",
+ "profile": "https://github.com/DeveshChau",
+ "contributions": [
+ "code",
+ "bug",
+ "challenge"
+ ]
+ },
+ {
+ "login": "stillst",
+ "name": "stillst",
+ "avatar_url": "https://avatars.githubusercontent.com/u/1463098?v=4",
+ "profile": "https://github.com/stillst",
+ "contributions": [
+ "challenge",
+ "translation-ru"
+ ]
+ },
  {
  "login": "alan-bio",
  "name": "Alan Dragicevich",
@@ -94,26 +126,6 @@
  "code"
  ]
  },
- {
- "login": "jdegand",
- "name": "J. Degand",
- "avatar_url": "https://avatars.githubusercontent.com/u/70610011?v=4",
- "profile": "https://github.com/jdegand",
- "contributions": [
- "doc"
- ]
- },
- {
- "login": "DeveshChau",
- "name": "Devesh Chaudhari",
- "avatar_url": "https://avatars.githubusercontent.com/u/9509673?v=4",
- "profile": "https://github.com/DeveshChau",
- "contributions": [
- "code",
- "bug",
- "challenge"
- ]
- },
  {
  "login": "dmmishchenko",
  "name": "Dmitriy Mishchenko",
@@ -157,13 +169,32 @@
  "avatar_url": "https://avatars.githubusercontent.com/u/142346548?v=4",
  "profile": "https://github.com/kabrunko-dev/",
  "contributions": [
- "translation-pt-BR",
+ "code",
+ "translation-pt",
+ "doc"
+ ]
+ },
+ {
+ "login": "ErickRodrCodes",
+ "name": "Erick Rodriguez",
+ "avatar_url": "https://avatars.githubusercontent.com/u/1978642?v=4",
+ "profile": "http://www.streamoverlaypro.com",
+ "contributions": [
+ "translation-es"
+ ]
+ },
+ {
+ "login": "eduardoRoth",
+ "name": "Eduardo Roth",
+ "avatar_url": "https://avatars.githubusercontent.com/u/5419161?v=4",
+ "profile": "https://eduardoroth.dev",
+ "contributions": [
  "doc",
- "code"
+ "translation-es"
  ]
  }
  ],
  "contributorsPerLine": 7,
  "linkToUsage": true,
  "commitType": "docs"
-}
+}

.github/workflows/close-inactive-pr.yml

@@ -16,10 +16,12 @@ jobs:
  days-before-issue-close: -1
  stale-issue-label: 'stale'
  stale-issue-message: 'This issue is stale because it has been open for 20 days with no activity.'
+ exempt-issue-labels: 'long-term'
  days-before-pr-stale: 20
  days-before-pr-close: 7
  stale-pr-label: 'stale'
  stale-pr-message: 'This pull request is stale because it has been open for 20 days with no activity.'
  close-pr-message: 'This pull request was closed because it has been inactive for 7 days since being marked as stale.'
  only-pr-labels: 'answer'
+ exempt-pr-labels: 'challenge-creation, long-term'
  repo-token: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -19,7 +19,6 @@ node_modules
 
 # IDE - VSCode
 .vscode/*
-!.vscode/settings.json
 !.vscode/tasks.json
 !.vscode/launch.json
 !.vscode/extensions.json
@@ -41,4 +40,4 @@ Thumbs.db
 .angular
 
 TODO.md
-.nx/cache
+.nx/cache

.vscode/settings.json

@@ -1,3 +1,6 @@
 {
- "eslint.validate": ["json"]
+ "eslint.validate": [
+ "json"
+ ],
+ "cSpell.language": "en,es-ES"
 }

README.md

@@ -24,7 +24,7 @@ If you would like to propose a challenge, this project is open source, so feel f
 
 ## Challenges
 
-Check [all 40 challenges](https://angular-challenges.vercel.app/)
+Check [all 43 challenges](https://angular-challenges.vercel.app/)
 
 ## Contributors ✨
 
@@ -35,20 +35,25 @@ Check [all 40 challenges](https://angular-challenges.vercel.app/)
  <tbody>
  <tr>
   <td align="center" valign="top" width="14.28%"><a href="https://thomaslaforge.dev/home"><img src="https://avatars.githubusercontent.com/u/30832608?v=4?s=100" width="100px;" alt="Laforge Thomas"/><br /><sub><b>Laforge Thomas</b></sub></a><br /><a href="#challenge-tomalaforge" title="Create a challenge">🧩</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomalaforge" title="Code">💻</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomalaforge" title="Documentation">📖</a> <a href="#content-tomalaforge" title="Content">🖋</a> <a href="#ideas-tomalaforge" title="Ideas, Planning, & Feedback">🤔</a> <a href="#design-tomalaforge" title="Design">🎨</a> <a href="#translation-fr-tomalaforge" title="Translate in French">🇫🇷</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/jdegand"><img src="https://avatars.githubusercontent.com/u/70610011?v=4?s=100" width="100px;" alt="J. Degand"/><br /><sub><b>J. Degand</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=jdegand" title="Documentation">📖</a> <a href="#content-jdegand" title="Content">🖋</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=jdegand" title="Code">💻</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/DeveshChau"><img src="https://avatars.githubusercontent.com/u/9509673?v=4?s=100" width="100px;" alt="Devesh Chaudhari"/><br /><sub><b>Devesh Chaudhari</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=DeveshChau" title="Code">💻</a> <a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3ADeveshChau" title="Bug reports">🐛</a> <a href="#challenge-DeveshChau" title="Create a challenge">🧩</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/stillst"><img src="https://avatars.githubusercontent.com/u/1463098?v=4?s=100" width="100px;" alt="stillst"/><br /><sub><b>stillst</b></sub></a><br /><a href="#challenge-stillst" title="Create a challenge">🧩</a> <a href="#translation-ru-stillst" title="Translate in Russian">🇷🇺</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://github.com/alan-bio"><img src="https://avatars.githubusercontent.com/u/31838230?v=4?s=100" width="100px;" alt="Alan Dragicevich"/><br /><sub><b>Alan Dragicevich</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=alan-bio" title="Documentation">📖</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://github.com/edimitchel"><img src="https://avatars.githubusercontent.com/u/2922851?v=4?s=100" width="100px;" alt="Michel EDIGHOFFER"/><br /><sub><b>Michel EDIGHOFFER</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=edimitchel" title="Documentation">📖</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://github.com/gsgonzalez88"><img src="https://avatars.githubusercontent.com/u/39884678?v=4?s=100" width="100px;" alt="Gerardo Sebastian Gonzalez"/><br /><sub><b>Gerardo Sebastian Gonzalez</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=gsgonzalez88" title="Documentation">📖</a></td>
-  <td align="center" valign="top" width="14.28%"><a href="https://github.com/marryday"><img src="https://avatars.githubusercontent.com/u/57489315?v=4?s=100" width="100px;" alt="Evseev Yuriy"/><br /><sub><b>Evseev Yuriy</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3Amarryday" title="Bug reports">🐛</a></td>
-  <td align="center" valign="top" width="14.28%"><a href="https://github.com/tomer953"><img src="https://avatars.githubusercontent.com/u/1807493?v=4?s=100" width="100px;" alt="Tomer953"/><br /><sub><b>Tomer953</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3Atomer953" title="Bug reports">🐛</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomer953" title="Documentation">📖</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomer953" title="Code">💻</a></td>
-  <td align="center" valign="top" width="14.28%"><a href="https://github.com/jdegand"><img src="https://avatars.githubusercontent.com/u/70610011?v=4?s=100" width="100px;" alt="J. Degand"/><br /><sub><b>J. Degand</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=jdegand" title="Documentation">📖</a></td>
  </tr>
  <tr>
-  <td align="center" valign="top" width="14.28%"><a href="https://github.com/DeveshChau"><img src="https://avatars.githubusercontent.com/u/9509673?v=4?s=100" width="100px;" alt="Devesh Chaudhari"/><br /><sub><b>Devesh Chaudhari</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=DeveshChau" title="Code">💻</a> <a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3ADeveshChau" title="Bug reports">🐛</a> <a href="#challenge-DeveshChau" title="Create a challenge">🧩</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/marryday"><img src="https://avatars.githubusercontent.com/u/57489315?v=4?s=100" width="100px;" alt="Evseev Yuriy"/><br /><sub><b>Evseev Yuriy</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3Amarryday" title="Bug reports">🐛</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/tomer953"><img src="https://avatars.githubusercontent.com/u/1807493?v=4?s=100" width="100px;" alt="Tomer953"/><br /><sub><b>Tomer953</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/issues?q=author%3Atomer953" title="Bug reports">🐛</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomer953" title="Documentation">📖</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=tomer953" title="Code">💻</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://github.com/dmmishchenko"><img src="https://avatars.githubusercontent.com/u/51910160?v=4?s=100" width="100px;" alt="Dmitriy Mishchenko"/><br /><sub><b>Dmitriy Mishchenko</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=dmmishchenko" title="Documentation">📖</a></td>
   <td align="center" valign="top" width="14.28%"><a href="http://www.sagardev.com.np"><img src="https://avatars.githubusercontent.com/u/30800393?v=4?s=100" width="100px;" alt="Sagar Devkota"/><br /><sub><b>Sagar Devkota</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=Sagardevkota" title="Documentation">📖</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=Sagardevkota" title="Code">💻</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://nelsonguti.dev/"><img src="https://avatars.githubusercontent.com/u/62297014?v=4?s=100" width="100px;" alt="Nelson Gutierrez"/><br /><sub><b>Nelson Gutierrez</b></sub></a><br /><a href="#translation-es-nelsongutidev" title="Translate in Spanish">🇪🇸</a></td>
   <td align="center" valign="top" width="14.28%"><a href="https://github.com/ho-ssain"><img src="https://avatars.githubusercontent.com/u/61125174?v=4?s=100" width="100px;" alt="Hossain K. M."/><br /><sub><b>Hossain K. M.</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=ho-ssain" title="Documentation">📖</a></td>
-  <td align="center" valign="top" width="14.28%"><a href="https://github.com/kabrunko-dev/"><img src="https://avatars.githubusercontent.com/u/142346548?v=4?s=100" width="100px;" alt="Diogo Nishikawa"/><br /><sub><b>Diogo Nishikawa</b></sub></a><br /><a href="#translation-pt-BR-kabrunko-dev" title="Translate in Brazilian Portuguese">🇧🇷</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=kabrunko-dev" title="Documentation">📖</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=kabrunko-dev" title="Code">💻</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://github.com/kabrunko-dev/"><img src="https://avatars.githubusercontent.com/u/142346548?v=4?s=100" width="100px;" alt="Diogo Nishikawa"/><br /><sub><b>Diogo Nishikawa</b></sub></a><br /><a href="#translation-pt-kabrunko-dev" title="Translate in Portuguese">🇵🇹</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=kabrunko-dev" title="Documentation">📖</a> <a href="https://github.com/tomalaforge/angular-challenges/commits?author=kabrunko-dev" title="Code">💻</a></td>
+ </tr>
+ <tr>
+  <td align="center" valign="top" width="14.28%"><a href="http://www.streamoverlaypro.com"><img src="https://avatars.githubusercontent.com/u/1978642?v=4?s=100" width="100px;" alt="Erick Rodriguez"/><br /><sub><b>Erick Rodriguez</b></sub></a><br /><a href="#translation-es-ErickRodrCodes" title="Translate in Spanish">🇪🇸</a></td>
+  <td align="center" valign="top" width="14.28%"><a href="https://eduardoroth.dev"><img src="https://avatars.githubusercontent.com/u/5419161?v=4?s=100" width="100px;" alt="Eduardo Roth"/><br /><sub><b>Eduardo Roth</b></sub></a><br /><a href="https://github.com/tomalaforge/angular-challenges/commits?author=eduardoRoth" title="Documentation">📖</a> <a href="#translation-es-eduardoRoth" title="Translate in Spanish">🇪🇸</a></td>
  </tr>
  </tbody>
  <tfoot>

apps/angular/anchor-scrolling/jest.config.ts

@@ -2,7 +2,7 @@
 export default {
  displayName: 'angular-anchor-scrolling',
  preset: '../../../jest.preset.js',
- setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
+ setupFilesAfterEnv: ['<rootDir>/src/subscription-setup.ts'],
  coverageDirectory: '../../../coverage/apps/angular/anchor-scrolling',
  transform: {
  '^.+\\.(ts|mjs|js|html)$': [

apps/angular/anchor-scrolling/src/app/app.component.ts

@@ -5,6 +5,8 @@ import { RouterOutlet } from '@angular/router';
  standalone: true,
  imports: [RouterOutlet],
  selector: 'app-root',
- template: ` <router-outlet></router-outlet> `,
+ template: `
+ <router-outlet></router-outlet>
+ `,
 })
 export class AppComponent {}

apps/angular/anchor-scrolling/src/app/foo.component.ts

@@ -7,7 +7,7 @@ import { NavButtonComponent } from './nav-button.component';
  selector: 'app-foo',
  template: `
  Welcome to foo page
- <nav-button href="home" class="fixed top-3 left-1/2">Home Page</nav-button>
+ <nav-button href="home" class="fixed left-1/2 top-3">Home Page</nav-button>
  <div class="h-screen bg-blue-200">section 1</div>
  <div class="h-screen bg-red-200">section 2</div>
  `,

apps/angular/anchor-scrolling/src/app/home.component.ts

@@ -6,7 +6,7 @@ import { NavButtonComponent } from './nav-button.component';
  imports: [NavButtonComponent],
  selector: 'app-home',
  template: `
- <nav-button href="/foo" class="fixed top-3 left-1/2">Foo Page</nav-button>
+ <nav-button href="/foo" class="fixed left-1/2 top-3">Foo Page</nav-button>
  <div id="top" class="h-screen bg-gray-500">
  Empty
  <nav-button href="#bottom">Scroll Bottom</nav-button>

apps/angular/anchor-scrolling/src/index.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
  <head>
  <meta charset="utf-8" />