Revert "Debug patch for Bug#17665497 DATANODE CRASH IN DBTUPDISKALLOC.CPP DBTUP (LINE: 848) 0X00000000"

This reverts commit 30e00fcf0ed2f00747797e417266d3603ad82f15.

Author: zmur

storage/ndb/src/kernel/blocks/dbtup/DbtupDiskAlloc.cpp

@@ -1975,24 +1975,6 @@ Dbtup::disk_restart_alloc_extent(EmulatedJamBuffer* jamBuf,
 ndbassert(old.p->m_free_matrix_pos == RNIL);
 Uint32 pos= alloc.calc_extent_pos(old.p);
 Local_extent_info_list new_list(c_extent_pool, alloc.m_free_extents[pos]);
-#if defined VM_TRACE || defined ERROR_INSERT
- ndbrequire(!"Bug17665497: debugging suspect code path.");
- /**
- * old is already in list with head alloc.m_extent_list.
- * Before adding it to new_list it should be removed from
- * previous list. Otherwise that list will become corrupt
- * and Dbtup::disk_page_get_allocated() will eventually
- * calculate wrong free value. Possibly it could also end
- * up with derefering a released Extent_info.
- *
- * Something like below should be added, but since list is
- * single linked remove is harder, might need to make list
- * double linked.
- *
- * Local_fragment_extent_list list1(c_extent_pool, alloc.m_extent_list);
- * list1.remove(old);
- */
-#endif
  new_list.addFirst(old);
 old.p->m_free_matrix_pos= pos;
  }
@@ -2057,9 +2039,6 @@ Dbtup::disk_page_get_allocated(const Tablerec* tabPtrP,
  Ptr<Extent_info> extentPtr;
  for (list.first(extentPtr); !extentPtr.isNull(); list.next(extentPtr))
  {
-#if defined VM_TRACE || defined ERROR_INSERT
- ndbrequire(extentPtr.p->m_free_matrix_pos == RNIL);
-#endif
  cnt++;
  free += extentPtr.p->m_free_space;
  }