Introduce borderRadius CSS variable #1691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| While previewing my changes I noticed that currently the function detail header is one of the few elements without a Current: With Let me know what you think about it and I could add it to the PR. |
Contributor
| I haven't tried this out, but are we sure making all values the same is an improvement? For example, I can imagine the designer(s) deliberately chose a smaller radius for code blocks, which would go from 2px to 4px here. |
Member
| I would not change the 2px ones but the other ones look consistent to me. :) unless you have further objections @DavidOliver. |
Contributor
| 👍 🙏 🙂 |
Member
| 💚 💙 💜 💛 ❤️ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As requested in #1649