Skip to content

fix: allow renaming between main entrypoint files #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: allow renaming between main entrypoint files #1679

merged 1 commit into from
Mar 6, 2025

Conversation

@dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Mar 5, 2025

Fixes a regression introduced in #1563 that somewhat broke #1474 since you can't rename main.js to main.mjs.
@coveralls
Copy link

coveralls commented Mar 5, 2025

Coverage Status

coverage: 87.502% (-0.1%) from 87.604%
when pulling 2ab1697 on fix/rename-main-entry-points
into 9111d84 on main.
@dsanders11 dsanders11 marked this pull request as ready for review March 5, 2025 22:44
@dsanders11 dsanders11 requested review from a team and codebytere as code owners March 5, 2025 22:44
BlackHole1
BlackHole1 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@BlackHole1 BlackHole1 merged commit 39848ed into main Mar 6, 2025
9 checks passed
@BlackHole1 BlackHole1 deleted the fix/rename-main-entry-points branch March 6, 2025 01:45
@Sanjai-Shaarugesh Sanjai-Shaarugesh mentioned this pull request Mar 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@dsanders11 @coveralls @BlackHole1