initial spec for pipe input #1385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| great! I'll get that in shortly. Thanks. |
| this has been merged. I made 2 small modifications and it looks like I have to improve my manual merge workflow because it didn't automatically close this pr. I guess it must be because I squashed the commits. But the other thing which is weird, it did not recognized you as a contributor to both files, if you look at the history, it lists your name & email but does not link to yout github account. Something is eluding me... |
| for the record, it did not attach my commit here & closed the PR because I wrote "closes 1385" and not "closes #1385"... :P |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As discussed in #942, input/pipe needs specs to evolve. Here is a proposal of an initial version