Skip to content

Conversation

@howardhuanghua
Copy link

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.
tlrx and others added 30 commits November 23, 2018 09:26
…Action (elastic#35540) This pull request exposes two new methods in the IndexShard and TransportReplicationAction classes in order to allow transport replication actions to acquire all index shard operation permits for their execution. It first adds the acquireAllPrimaryOperationPermits() and the acquireAllReplicaOperationsPermits() methods to the IndexShard class which allow to acquire all operations permits on a shard while exposing a Releasable. It also refactors the TransportReplicationAction class to expose two protected methods (acquirePrimaryOperationPermit() and acquireReplicaOperationPermit()) that can be overridden when a transport replication action requires the acquisition of all permits on primary and/or replica shard during execution. Finally, it adds a TransportReplicationAllPermitsAcquisitionTests which illustrates how a transport replication action can grab all permits before adding a cluster block in the cluster state, making subsequent operations that requires a single permit to fail). Related to elastic elastic#33888
This change fixes analyzed prefix queries in `query_string` to be ignored if all terms are removed during the analysis. Closes elastic#31702
Today when rolling a transog generation we copy the checkpoint from `translog.ckp` to `translog-nnnn.ckp` using a simple `Files.copy()` followed by appropriate `fsync()` calls. The copy operation is not atomic, so if we crash at the wrong moment we can leave an incomplete checkpoint file on disk. In practice the checkpoint is so small that it's either empty or fully written. However, we do not correctly handle the case where it's empty when the node restarts. In contrast, in `recoverFromFiles()` we _do_ copy the checkpoint atomically. This commit extracts the atomic copy operation from `recoverFromFiles()` and re-uses it in `rollGeneration()`.
Adds a verification mode for read-only repositories. It also makes the extra bucket check on repository creation obsolete, which fixes elastic#35703.
…lastic#35815) This code is only necessary up to indices created with version 5.x while 7.0 only supports indices created with 6.x or 7.0.
This PR was backported to 6.x, so the extra BWC conditions are not needed anymore
NULLIF returns null if the 2 expressions are equal or the expr1 otherwise. Closes: elastic#35818
Code that operates on-top of the engine requires all readers returned to be unwrapped into ElasticsearchDirectoryReader. The special reader the FrozenEngine uses wasn't wrapped.
…5837) Acquiring a searcher is unnecessary to determine if a refresh is necessary since read-only engines never refresh. Closes elastic#35785
* Disable snapshot repo verification temporarily because it runs into HTTP-500 in 6.6.0-SNAPSHOT * Relates elastic#35874
* Introduced "client.id" parameter for REST requests * Bug that made the Verifier run twice, fixed in the Analyzer * Single node IT and unit testing
…tic#35535) The `wait_for_metadata_version` parameter will instruct the cluster state api to only return a cluster state until the metadata's version is equal or greater than the version specified in `wait_for_metadata_version`. If the specified `wait_for_timeout` has expired then a timed out response is returned. (a response with no cluster state and wait for timed out flag set to true) In the case metadata's version is equal or higher than `wait_for_metadata_version` then the api will immediately return. This feature is useful to avoid external components from constantly polling the cluster state to whether somethings have changed in the cluster state's metadata.
This commits adds support for the Get Roles API to the HLRC Relates: elastic#29827
This commit simplifies the throttling logic in InitialSearchPhase and removes some asserts from it. Also, a few formatting changes are applied to its code and surrounding classes.
This test fails on CI because of an inappropriate assertion, which is I think a leftover and has no real value.
More like this query allows to provide identifiers of documents to be retrieved as like/unlike items. It can happen that at retrieval time an error is thrown, for instance caused by missing routing value when `_routing` is set required in the mapping. Instead of ignoring such error and returning no documents for the query, the error should be re-thrown and returned to users. As part of this change also mget and mtermvectors are unified in the way they throw such exception like it happens in other places, so that a `RoutingMissingException` is raised. Closes elastic#29678
This operator handles nulls in different way than the normal `=`. If one of the operants is `null` and the other not it returns `false`. If both operants are `null` it returns `true`. Therefore in contrary to `=`, which returns `null` if at least one of the operants is `null`, this one never returns `null` as a result. Closes: elastic#35871
Today we don't respect the indices options when they are passed as request parameters to the `_msearch` endpoint. This is unintuitive and doesn't cause any errors. This changes uses the top-level indices options as the defaults for each sub search-request. Closes elastic#35851
Due to some unresolvable type conflict between the expected definition in JDBC vs ODBC, the driver mode is now passed over so that certain command can change their results accordingly (in this case SYS COLUMNS) Fix elastic#35376
jakelandis and others added 16 commits November 26, 2018 09:35
This commit removes the redundant (and incorrect) JAVACLASS and JAVAFILE grok patterns. This helps to keep parity with Logstash's patterns. See also: logstash-plugins/logstash-patterns-core#237 closes elastic#35699
Add GREATEST(expr1, expr2, ... exprN) and LEAST(expr1, expr2, exprN) functions which are in the family of CONDITIONAL functions. Implementation follows PostgreSQL behaviour, so the functions return `NULL` when all of their arguments evaluate to `NULL`. Renamed `CoalescePipe` and `CoalesceProcessor` to `ConditionalPipe` and `ConditionalProcessor` respectively, to be able to reuse them for `Greatest` and `Least` evaluations. To achieve that `ConditionalOperation` has been added to differentiate between the functionalities at execution time. Closes: elastic#35878
This commit adds the support for exists query in the sorted execution mode of the `composite` aggregation. We'll execute the aggregation from the sorted points and use early termination if the main query is an `exists` query over the first source of the `composite` aggregation.
Improves handling of malformed geo_points when `ignore_malformed` is set to true Closes elastic#35419
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Adds HLRC documentation for the Explain Lifecycle API.
This removes the option to run a cluster without enforcing the cluster-wide shard limit, making strict enforcement the default and only behavior. The limit can still be adjusted as desired using the cluster settings API.
This commit adds back bundling of all deps of the sql jdbc jar. This was lost in a refactoring of how the shadow plugin is handled for the entire elasticsearch project.
Watcher still exposes some dates as joda DateTime objects. This commit adds back joda to the painless whitelist so they can still be accessed. closes elastic#35913
@howardhuanghua howardhuanghua merged commit d70ccfc into elasticsearch-cn:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment