Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 22, 2024

Contributes to #5264

Previews:

Corresponding ESS PR: #5631

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Large Issues that require significant planning, research, writing, and testing Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.15.0 labels Jul 22, 2024
@nastasha-solomon nastasha-solomon self-assigned this Jul 22, 2024
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Jul 23, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review July 23, 2024 17:43
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner July 23, 2024 17:43
approksiu and others added 3 commits September 24, 2024 17:13
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
approksiu
approksiu previously approved these changes Sep 24, 2024
Copy link
Contributor

@approksiu approksiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just left a few suggestions for your consideration!

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more line edits, thanks! Ping again for approval!

nastasha-solomon and others added 13 commits October 1, 2024 23:34
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nastasha-solomon
Copy link
Contributor Author

Verified that this feature appears in the UI on prod and works as intended.

@nastasha-solomon nastasha-solomon merged commit 4cbfd6d into main Oct 16, 2024
4 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-5264-manual-rule-run branch October 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Docset: Serverless Issues for Serverless Security Effort: Large Issues that require significant planning, research, writing, and testing Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine

9 participants