Skip to content

Conversation

@benironside
Copy link
Contributor

@benironside benironside commented Aug 3, 2022

Fixes #2213 by creating a new page in the Dashboards section of docs that describes how to set up and understand the Kubernetes dashboard.

Also fixes #2214 by updating the Session View doc to mention K8s data.

Previews:

@zizhouW
Copy link

zizhouW commented Aug 4, 2022

This is awesome! Thank you @benironside

We are wondering if it's worth mentioning in this doc that the data source used in the kubernetes dashboard is the logs pattern of the securitySolution:defaultIndex from advanced settings, which is configurable and is used by the rest of security solution pages.

image

This is useful when users have a cross cluster set up, where they will need to change the default logs-* pattern to something like *:logs-* to see data across several clusters.

An alternative suggested by Glo is that we can mention it in the release note.
cc @qcorporation

@qcorporation qcorporation requested a review from lrishi August 4, 2022 15:50
@benironside
Copy link
Contributor Author

benironside commented Aug 8, 2022

Thanks for your reviews @zizhouW, @norrietaylor, and @qcorporation, I've pushed updates in response to your feedback and suggestions, so please take another look at the preview and let me know whether your concerns are resolved or you'd like to see some additional changes!

@benironside benironside mentioned this pull request Aug 22, 2022
20 tasks
@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Aug 23, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

Hi Team,

This feature is not taken care by our team, so we are not the right person to review the Doc.

Thanks!

@qcorporation
Copy link
Contributor

qcorporation commented Aug 23, 2022

YAML files to use for setup can be found by instructing the user to fetch the yaml file
curl -L -O https://raw.githubusercontent.com/elastic/endpoint/main/releases/8.4.0/kubernetes/deploy/elastic-endpoint-security.yaml

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback for your review. 👍

@benironside benironside merged commit 6af95d4 into main Aug 24, 2022
@benironside benironside deleted the issue-2213-big branch August 24, 2022 10:27
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
* First draft of Kubernetes Dashboard doc * Fixes a typo * Fixes table format bug * fixes for,attong * Addresses Norrie's feedback * Adds "kubernetes-specific data in session view" section * Addresses Quan's feedback * Incorporates Jack's feedback * Addresses Jack's feedback * Fixes build errors * Incorporate Jack's feedback * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * troubleshoot build failure * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Nastasha's and Joe's feedback * Updates the Session View page to mention K8s data * troubleshoot build * troubleshoot build * Incorporates feedback * Incorporates Janeen's, Nick's, and Quan's feedback * Reorg to better match other dashboards pages * Minor edit * Final nits Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 6af95d4)
benironside added a commit that referenced this pull request Aug 24, 2022
* First draft of Kubernetes Dashboard doc * Fixes a typo * Fixes table format bug * fixes for,attong * Addresses Norrie's feedback * Adds "kubernetes-specific data in session view" section * Addresses Quan's feedback * Incorporates Jack's feedback * Addresses Jack's feedback * Fixes build errors * Incorporate Jack's feedback * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * troubleshoot build failure * Update docs/dashboards/kubernetes-dashboard.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporates Nastasha's and Joe's feedback * Updates the Session View page to mention K8s data * troubleshoot build * troubleshoot build * Incorporates feedback * Incorporates Janeen's, Nick's, and Quan's feedback * Reorg to better match other dashboards pages * Minor edit * Final nits Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 6af95d4) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Kubernetes readyforQA PRs that are ready for QA review. v8.4.0

8 participants