[DOCS] [AWP] [8.2] Session View topic #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
benironside requested review from dimadavid, mitodrummer, norrietaylor, qcorporation and snehsach19 
| From either of these tabs, click the *Open Session View* icon for an event or session: | ||
| | ||
| [role="screenshot"] | ||
| image::images/session-view-hosts-page-sessions-tab-labeled.png[] |
Contributor
There was a problem hiding this comment.
The screenshots might have to be updated based upon this ticket: elastic/kibana#129923 which we "might" add into the 8.2 release
Contributor Author
There was a problem hiding this comment.
thanks, subscribed to that issue. NP to update screenshots as needed.
benironside dismissed dimadavid’s stale review I made the requested changes, and Dima reviewed again and agreed it's improved
dimadavid previously requested changes Apr 21, 2022
dimadavid left a comment
dimadavid left a comment There was a problem hiding this comment.
it would be helpful to users if the following screen captures are shown in context. a full command line from session view with these labels/buttons:
docs/detections/images/session-view-script-button.png
docs/detections/images/session-view-hosts-page-sessions-tab-labeled.png
benironside dismissed dimadavid’s stale review Updated screenshots to show full command-line context
jmikell821 reviewed Apr 26, 2022
Contributor
jmikell821 left a comment
jmikell821 left a comment There was a problem hiding this comment.
Left a few comments/suggestions. Looks good - thanks!
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
| Hi @benironside, We have reported the 01 issue for the docs related to this PR here: We will validate this PR once the above issue is fixed. Thanks! |
ghost removed the | Hi @benironside, We tested the linked docs for the reported bugs and found that all the docs are correctly updated as per the latest UI. So we are good to go ahead and merge the changes. Marking this ticket as 'QA validated'. Thanks! |
mergify bot pushed a commit that referenced this pull request Apr 28, 2022
* Add first draft of Session View topic * Fix bugs * Testing alternative section headers * Troubleshoot modified headers, update image * Minor fixes * Adds information about what SV displays * Changes references to "agent" to "Endpoint Security" * Remove references to output * Changes "details pane" to "details panel" * Addresses Mike's, Norrie's, and David's feedback * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporate Joe's feedback * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Address feedback, update images to latest version of SV * fixes build error * troubleshoots images * Troubleshoots image resolution * Fixes a stray period * update button and badge screenshots * Update docs/detections/session-view.asciidoc Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Incorporates Janeen's feedback * Addresses bug where Authentications tab was present Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit e8a0c07)
benironside added a commit that referenced this pull request Apr 28, 2022
* Add first draft of Session View topic * Fix bugs * Testing alternative section headers * Troubleshoot modified headers, update image * Minor fixes * Adds information about what SV displays * Changes references to "agent" to "Endpoint Security" * Remove references to output * Changes "details pane" to "details panel" * Addresses Mike's, Norrie's, and David's feedback * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/detections/session-view.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Incorporate Joe's feedback * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/detections/session-view.asciidoc Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Address feedback, update images to latest version of SV * fixes build error * troubleshoots images * Troubleshoots image resolution * Fixes a stray period * update button and badge screenshots * Update docs/detections/session-view.asciidoc Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> * Incorporates Janeen's feedback * Addresses bug where Authentications tab was present Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit e8a0c07) Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #1781 by creating a new documentation page that describes the version of Session View that will be released in 8.2.
Please see the preview here: Session View, and add feedback as suggestions or comments.
I requested reviews from several AWP team leads, please feel free to add members of your teams as reviewers as well.