Add rule docs for 8.0 rule changes #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jmikell821 requested review from benironside, joepeeples and nastasha-solomon 
Contributor
| @brokensound77 looks like there's an invalid reference that's causing the build to fail. |
w0rk3r approved these changes Feb 10, 2022
joepeeples reviewed Feb 10, 2022
Contributor
joepeeples left a comment
joepeeples left a comment There was a problem hiding this comment.
Thank you @brokensound77 for keeping the rules updated!
The vast majority of these comments are to change the version from 8.0 to 8.0.0, which matches usage for other versions. Some various small edits are mixed in too.
| information about a rule's changes, see the rule's description page. | ||
| | ||
| [float] | ||
| === 8.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| === 8.0 | |
| === 8.0.0 |
docs/detections/prebuilt-rules/rule-details/account-password-reset-remotely.asciidoc Outdated Show resolved Hide resolved
.../detections/prebuilt-rules/rule-details/adversary-behavior-detected-elastic-endgame.asciidoc Outdated Show resolved Hide resolved
.../detections/prebuilt-rules/rule-details/adversary-behavior-detected-elastic-endgame.asciidoc Outdated Show resolved Hide resolved
...detections/prebuilt-rules/rule-details/application-added-to-google-workspace-domain.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/prebuilt-rules-reference.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/prebuilt-rules-reference.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/prebuilt-rules-reference.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/prebuilt-rules-reference.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/prebuilt-rules-reference.asciidoc Outdated Show resolved Hide resolved
joepeeples reviewed Feb 10, 2022
Contributor
joepeeples left a comment
joepeeples left a comment There was a problem hiding this comment.
Thank you @brokensound77 for keeping the rules updated!
The vast majority of these comments are to change the version from 8.0 to 8.0.0, which matches usage for other versions. Some various small edits are mixed in too.
Contributor Author
Thank you @joepeeples, great catch!! I just pushed an update to address that - hopefully I didn't miss anything 😅 |
Contributor Author
| Just as with previous docs reviews, if there are any changes to the rules contents, we can parse out the feedback and create a PR in the rules repo and merge this. cc: @w0rk3r |
mergify bot pushed a commit that referenced this pull request Feb 15, 2022
* Add rule docs for 8.0 rule changes * remove missing link for aws-ec2-vm-export-failure-history * update script to not add history without changelog * remove missing history links * remove extra version bump * remove debug line from script * update all occurrences of 8.0 to 8.0.0 Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 9f79109)
mergify bot pushed a commit that referenced this pull request Feb 15, 2022
* Add rule docs for 8.0 rule changes * remove missing link for aws-ec2-vm-export-failure-history * update script to not add history without changelog * remove missing history links * remove extra version bump * remove debug line from script * update all occurrences of 8.0 to 8.0.0 Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 9f79109)
jmikell821 pushed a commit that referenced this pull request Feb 16, 2022
* Add rule docs for 8.0 rule changes * remove missing link for aws-ec2-vm-export-failure-history * update script to not add history without changelog * remove missing history links * remove extra version bump * remove debug line from script * update all occurrences of 8.0 to 8.0.0 Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 9f79109) Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
jmikell821 pushed a commit that referenced this pull request Feb 16, 2022
* Add rule docs for 8.0 rule changes * remove missing link for aws-ec2-vm-export-failure-history * update script to not add history without changelog * remove missing history links * remove extra version bump * remove debug line from script * update all occurrences of 8.0 to 8.0.0 Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 9f79109) Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Doc updates for rule changes in 8.0
preview